You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@opennlp.apache.org by "kinow (via GitHub)" <gi...@apache.org> on 2023/03/04 21:35:52 UTC

[GitHub] [opennlp] kinow commented on a diff in pull request #516: OPENNLP-1474 Create tokenizer factories for other langs (Spanish, Italian, ...)

kinow commented on code in PR #516:
URL: https://github.com/apache/opennlp/pull/516#discussion_r1125562917


##########
opennlp-tools/src/main/java/opennlp/tools/tokenize/lang/Factory.java:
##########
@@ -43,18 +53,25 @@ public class Factory {
    */
   public Pattern getAlphanumeric(String languageCode) {

Review Comment:
   A good idea I think, +1 to both the enum and the jira (probably an epic, especially if we need to update sandbox components).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org