[GitHub] [skywalking-infra-e2e] fgksgf commented on a diff in pull request #79: Support non-fail-fast execution of test cases

[GitBox <gi...@apache.org>]

fgksgf commented on code in PR #79:
URL: https://github.com/apache/skywalking-infra-e2e/pull/79#discussion_r919003204


##########
examples/compose/e2e.yaml:
##########
@@ -51,6 +51,13 @@ verify:
     count: 10
     # the interval between two attempts, e.g. 10s, 1m.
     interval: 10s
+
+  setting:
+    # whether by fail-fast or not, e.g. true, false.
+    fail-fast: true
+    # verify the cases concurrently or not, e.g. true, false
+    concurrency: true

Review Comment:
   The concurrency feature is not implemented in this pr actually, so do not add it for now.



##########
internal/config/e2eConfig.go:
##########
@@ -136,6 +137,11 @@ type VerifyRetryStrategy struct {
 	Interval any `yaml:"interval"`
 }
 
+type VerifySetting struct {
+	FailFast    bool `yaml:"fail-fast"`
+	Concurrency bool `yaml:"concurrency"`

Review Comment:
   Ditto.



##########
commands/verify/verify.go:
##########
@@ -112,6 +114,9 @@ func DoVerifyAccordingConfig() error {
 				logger.Log.Warnf("verify case failure, will continue retry, %v", err)
 				time.Sleep(interval)
 			} else {
+				if failFast {

Review Comment:
   The logic is not correct, fix it plz



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org