You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shardingsphere.apache.org by "zhangliang@apache.org" <zh...@apache.org> on 2019/09/05 13:28:46 UTC
Talk about how to set committer bar
Hi ShardingSphere community,
There are 64 contributors for ShardingSphere, I want discuss about elected
more committers.
How to set committer bar? The previous rules can find here[1], they are:
1. Make contributions consistently during the past 6 months
2. Understand the core technology of ShardingSphere deeply
3. Obey the Code of Conduct
4. Submit high-quality content
5. Enable Google Two-factor authentication
The committer bar perhaps too high for new committers, can we define some
new rule to elect more committers?
[1] https://shardingsphere.apache.org/community/en/contribute/committer/
------------------
Liang Zhang (John)
Apache ShardingSphere & Dubbo
Re: Talk about how to set committer bar
Posted by "zhangliang@apache.org" <zh...@apache.org>.
> I agree that the 6 month guideline is probably too strict. Maybe replace
this with a general "Make several high-quality contributions to code,
documentation, or mail lists".
Agree. Maybe we can separate committers and PPMCs, the original rules are
suitable for PPMCs. For committers, better for using dynamic rules, and
just let PPMCs to vote.
------------------
Liang Zhang (John)
Apache ShardingSphere & Dubbo
Craig Russell <ap...@gmail.com> 于2019年9月7日周六 上午3:24写道：
> I agree that the 6 month guideline is probably too strict. Maybe replace
> this with a general "Make several high-quality contributions to code,
> documentation, or mail lists".
>
> The 6 month guideline might be more appropriate for PPMC members.
>
> And "understanding the core technology deeply" will disqualify most
> contributors. I would remove this guideline.
>
> I appreciate that ShardingSphere project takes suggestions like Justin's
> well.
>
> Regards,
> Craig
>
> > On Sep 5, 2019, at 6:46 AM, Justin Mclean <jm...@apache.org> wrote:
> >
> > Hi,
> >
> >> 1. Make contributions consistently during the past 6 months
> >> 2. Understand the core technology of ShardingSphere deeply
> >> 3. Obey the Code of Conduct
> >> 4. Submit high-quality content
> >> 5. Enable Google Two-factor authentication
> >
> > While each PPMC/PMC can set their own bar this is far too high IMO, in
> particular expecting someone to continually contribute for 6 months. Some
> project votes in committers after two or three contributions.
> >
> > Thanks,
> > Justin
>
> Craig L Russell
> clr@apache.org
>
>
Re: Talk about how to set committer bar
Posted by Craig Russell <ap...@gmail.com>.
I agree that the 6 month guideline is probably too strict. Maybe replace this with a general "Make several high-quality contributions to code, documentation, or mail lists".
The 6 month guideline might be more appropriate for PPMC members.
And "understanding the core technology deeply" will disqualify most contributors. I would remove this guideline.
I appreciate that ShardingSphere project takes suggestions like Justin's well.
Regards,
Craig
> On Sep 5, 2019, at 6:46 AM, Justin Mclean <jm...@apache.org> wrote:
>
> Hi,
>
>> 1. Make contributions consistently during the past 6 months
>> 2. Understand the core technology of ShardingSphere deeply
>> 3. Obey the Code of Conduct
>> 4. Submit high-quality content
>> 5. Enable Google Two-factor authentication
>
> While each PPMC/PMC can set their own bar this is far too high IMO, in particular expecting someone to continually contribute for 6 months. Some project votes in committers after two or three contributions.
>
> Thanks,
> Justin
Craig L Russell
clr@apache.org
Re: Talk about how to set committer bar
Posted by Zheng Feng <zh...@gmail.com>.
OK, I agree and maybe 2 or 3 Quality PR are enough to vote. We need more
committers to involve in the community.
zhangliang@apache.org <zh...@apache.org> 于2019年9月5日周四 下午10:17写道：
> > What is the "Quality PR" ? e.g. introduce a new feature or fix a very
> internal bug ?
>
> "Quality PR" means fix bug or dev new feature, "Quality PR" should
> exclude a PR only fix a typo
>
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
>
> Zheng Feng <zh...@gmail.com> 于2019年9月5日周四 下午10:12写道：
>
> > What is the "Quality PR" ? e.g. introduce a new feature or fix a very
> > internal bug ?
> >
> > zhangliang@apache.org <zh...@apache.org> 于2019年9月5日周四 下午10:08写道：
> >
> > > How about change `Make contributions consistently during the past 6
> > months`
> > > to `Submit 5 quality pull requests`?
> > >
> > > And we can discuss how many pull requests is necessary for elect.
> > >
> > > ------------------
> > >
> > > Liang Zhang (John)
> > > Apache ShardingSphere & Dubbo
> > >
> > >
> > > Zheng Feng <zh...@gmail.com> 于2019年9月5日周四 下午9:57写道：
> > >
> > > > I agree with Justin that we vote the committers more often.
> > > >
> > > > Justin Mclean <jm...@apache.org> 于2019年9月5日周四 下午9:46写道：
> > > >
> > > > > Hi,
> > > > >
> > > > > > 1. Make contributions consistently during the past 6 months
> > > > > > 2. Understand the core technology of ShardingSphere deeply
> > > > > > 3. Obey the Code of Conduct
> > > > > > 4. Submit high-quality content
> > > > > > 5. Enable Google Two-factor authentication
> > > > >
> > > > > While each PPMC/PMC can set their own bar this is far too high IMO,
> > in
> > > > > particular expecting someone to continually contribute for 6
> months.
> > > Some
> > > > > project votes in committers after two or three contributions.
> > > > >
> > > > > Thanks,
> > > > > Justin
> > > > >
> > > >
> > >
> >
>
Re: Talk about how to set committer bar
Posted by "zhangliang@apache.org" <zh...@apache.org>.
> What is the "Quality PR" ? e.g. introduce a new feature or fix a very
internal bug ?
"Quality PR" means fix bug or dev new feature, "Quality PR" should
exclude a PR only fix a typo
------------------
Liang Zhang (John)
Apache ShardingSphere & Dubbo
Zheng Feng <zh...@gmail.com> 于2019年9月5日周四 下午10:12写道：
> What is the "Quality PR" ? e.g. introduce a new feature or fix a very
> internal bug ?
>
> zhangliang@apache.org <zh...@apache.org> 于2019年9月5日周四 下午10:08写道：
>
> > How about change `Make contributions consistently during the past 6
> months`
> > to `Submit 5 quality pull requests`?
> >
> > And we can discuss how many pull requests is necessary for elect.
> >
> > ------------------
> >
> > Liang Zhang (John)
> > Apache ShardingSphere & Dubbo
> >
> >
> > Zheng Feng <zh...@gmail.com> 于2019年9月5日周四 下午9:57写道：
> >
> > > I agree with Justin that we vote the committers more often.
> > >
> > > Justin Mclean <jm...@apache.org> 于2019年9月5日周四 下午9:46写道：
> > >
> > > > Hi,
> > > >
> > > > > 1. Make contributions consistently during the past 6 months
> > > > > 2. Understand the core technology of ShardingSphere deeply
> > > > > 3. Obey the Code of Conduct
> > > > > 4. Submit high-quality content
> > > > > 5. Enable Google Two-factor authentication
> > > >
> > > > While each PPMC/PMC can set their own bar this is far too high IMO,
> in
> > > > particular expecting someone to continually contribute for 6 months.
> > Some
> > > > project votes in committers after two or three contributions.
> > > >
> > > > Thanks,
> > > > Justin
> > > >
> > >
> >
>
Re: Talk about how to set committer bar
Posted by Sheng Wu <wu...@gmail.com>.
Hi
> How about change `Make contributions consistently during the past 6
months`
to `Submit 5 quality pull requests`?
From this moment, I think this requirement is a little too high. We haven't
elected new committer for a long time, especially out of JD original team.
I think if 3+ code commits should be enough. Excluding typo makes sense to
me.
The bar is not static, with the community growth, it could be higher.
But, basically, I don't want this bar as a rule, just a ref and encourage
more commendation and proposal from existing PPMC.
Sheng Wu 吴晟
Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
Twitter, wusheng1108
Zheng Feng <zh...@gmail.com> 于2019年9月5日周四 上午7:12写道：
> What is the "Quality PR" ? e.g. introduce a new feature or fix a very
> internal bug ?
>
> zhangliang@apache.org <zh...@apache.org> 于2019年9月5日周四 下午10:08写道：
>
> > How about change `Make contributions consistently during the past 6
> months`
> > to `Submit 5 quality pull requests`?
> >
> > And we can discuss how many pull requests is necessary for elect.
> >
> > ------------------
> >
> > Liang Zhang (John)
> > Apache ShardingSphere & Dubbo
> >
> >
> > Zheng Feng <zh...@gmail.com> 于2019年9月5日周四 下午9:57写道：
> >
> > > I agree with Justin that we vote the committers more often.
> > >
> > > Justin Mclean <jm...@apache.org> 于2019年9月5日周四 下午9:46写道：
> > >
> > > > Hi,
> > > >
> > > > > 1. Make contributions consistently during the past 6 months
> > > > > 2. Understand the core technology of ShardingSphere deeply
> > > > > 3. Obey the Code of Conduct
> > > > > 4. Submit high-quality content
> > > > > 5. Enable Google Two-factor authentication
> > > >
> > > > While each PPMC/PMC can set their own bar this is far too high IMO,
> in
> > > > particular expecting someone to continually contribute for 6 months.
> > Some
> > > > project votes in committers after two or three contributions.
> > > >
> > > > Thanks,
> > > > Justin
> > > >
> > >
> >
>
Re: Talk about how to set committer bar
Posted by Zheng Feng <zh...@gmail.com>.
What is the "Quality PR" ? e.g. introduce a new feature or fix a very
internal bug ?
zhangliang@apache.org <zh...@apache.org> 于2019年9月5日周四 下午10:08写道：
> How about change `Make contributions consistently during the past 6 months`
> to `Submit 5 quality pull requests`?
>
> And we can discuss how many pull requests is necessary for elect.
>
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
>
> Zheng Feng <zh...@gmail.com> 于2019年9月5日周四 下午9:57写道：
>
> > I agree with Justin that we vote the committers more often.
> >
> > Justin Mclean <jm...@apache.org> 于2019年9月5日周四 下午9:46写道：
> >
> > > Hi,
> > >
> > > > 1. Make contributions consistently during the past 6 months
> > > > 2. Understand the core technology of ShardingSphere deeply
> > > > 3. Obey the Code of Conduct
> > > > 4. Submit high-quality content
> > > > 5. Enable Google Two-factor authentication
> > >
> > > While each PPMC/PMC can set their own bar this is far too high IMO, in
> > > particular expecting someone to continually contribute for 6 months.
> Some
> > > project votes in committers after two or three contributions.
> > >
> > > Thanks,
> > > Justin
> > >
> >
>
Re: Talk about how to set committer bar
Posted by Zheng Feng <zh...@gmail.com>.
I think we could also consider the activities in the community, such as
proposal a topic in the mailing list, raise an issue on the github and
involve in the discuss to help the other people to resolve the problem.
zhangliang@apache.org <zh...@apache.org> 于2019年9月5日周四 下午10:08写道：
> How about change `Make contributions consistently during the past 6 months`
> to `Submit 5 quality pull requests`?
>
> And we can discuss how many pull requests is necessary for elect.
>
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
>
> Zheng Feng <zh...@gmail.com> 于2019年9月5日周四 下午9:57写道：
>
> > I agree with Justin that we vote the committers more often.
> >
> > Justin Mclean <jm...@apache.org> 于2019年9月5日周四 下午9:46写道：
> >
> > > Hi,
> > >
> > > > 1. Make contributions consistently during the past 6 months
> > > > 2. Understand the core technology of ShardingSphere deeply
> > > > 3. Obey the Code of Conduct
> > > > 4. Submit high-quality content
> > > > 5. Enable Google Two-factor authentication
> > >
> > > While each PPMC/PMC can set their own bar this is far too high IMO, in
> > > particular expecting someone to continually contribute for 6 months.
> Some
> > > project votes in committers after two or three contributions.
> > >
> > > Thanks,
> > > Justin
> > >
> >
>
Re: Talk about how to set committer bar
Posted by "zhangliang@apache.org" <zh...@apache.org>.
Hi Zheng,
> Enable Google Two-factor authentication
Apache committer must Enable 2FA to login their github, otherwise he will
be removed from the organization.
------------------
Liang Zhang (John)
Apache ShardingSphere & Dubbo
zhangliang@apache.org <zh...@apache.org> 于2019年9月5日周四 下午10:07写道：
> How about change `Make contributions consistently during the past 6
> months` to `Submit 5 quality pull requests`?
>
> And we can discuss how many pull requests is necessary for elect.
>
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
>
> Zheng Feng <zh...@gmail.com> 于2019年9月5日周四 下午9:57写道：
>
>> I agree with Justin that we vote the committers more often.
>>
>> Justin Mclean <jm...@apache.org> 于2019年9月5日周四 下午9:46写道：
>>
>> > Hi,
>> >
>> > > 1. Make contributions consistently during the past 6 months
>> > > 2. Understand the core technology of ShardingSphere deeply
>> > > 3. Obey the Code of Conduct
>> > > 4. Submit high-quality content
>> > > 5. Enable Google Two-factor authentication
>> >
>> > While each PPMC/PMC can set their own bar this is far too high IMO, in
>> > particular expecting someone to continually contribute for 6 months.
>> Some
>> > project votes in committers after two or three contributions.
>> >
>> > Thanks,
>> > Justin
>> >
>>
>
Re: Talk about how to set committer bar
Posted by Justin Mclean <jm...@apache.org>.
Hi,
> Yeah, I aggree, if the person can show his commitment to the
> community, we should invite him or her to be a committer.
> But here is a problem what can we do if the person doesn't involove
> any activity of the community once he gets the committer right?
There is no problem with this. What have you lost if you make them a committer but they are not that active? Nothing. Often making people committers makes them more active or they may become active again in the future.
Thanks,
Justin
Re: Talk about how to set committer bar
Posted by Sheng Wu <wu...@gmail.com>.
From my personal experience, I would worry about this much.
In SkyWalking, some contributors(committers) come and go, but mostly, they
are around, keep contributing in different ways.
Such as answering questions, talk about the project in public conf/event.
Feedback about the use case in production env.
Mostly important, promoting project to people around their.
WIll be back if there is bug to fix and feature to upstream.
Basically, the contributors feedback because they are using the project.
If they leave just after promotion, so be it.
Think in this way, you have 20-30 committers, is that possible all of them
left in that moment?
Only yes, if project has serious issue. It is hard to leave when they put
you in production env.
Sheng Wu 吴晟
Apache SkyWalking, Apache ShardingSphere(Incubating), Zipkin
Twitter, wusheng1108
Willem Jiang <wi...@gmail.com> 于2019年9月5日周四 下午5:35写道：
> Yeah, I aggree, if the person can show his commitment to the
> community, we should invite him or her to be a committer.
> But here is a problem what can we do if the person doesn't involove
> any activity of the community once he gets the committer right?
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Fri, Sep 6, 2019 at 5:22 AM Justin Mclean <jm...@apache.org> wrote:
> >
> > Hi,
> >
> > > And we can discuss how many pull requests is necessary for elect.
> >
> > And contribution can be for things other than code or PRs.
> >
> > Thanks,
> > Justin
>
--
Sheng Wu
SkyWalking, Shardingsphere and Zipkin
Re: Talk about how to set committer bar
Posted by Willem Jiang <wi...@gmail.com>.
Yeah, I aggree, if the person can show his commitment to the
community, we should invite him or her to be a committer.
But here is a problem what can we do if the person doesn't involove
any activity of the community once he gets the committer right?
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Fri, Sep 6, 2019 at 5:22 AM Justin Mclean <jm...@apache.org> wrote:
>
> Hi,
>
> > And we can discuss how many pull requests is necessary for elect.
>
> And contribution can be for things other than code or PRs.
>
> Thanks,
> Justin
Re: Talk about how to set committer bar
Posted by Sheng Wu <wu...@gmail.com>.
+1 for this. For me, I think sharding is lacking about diversity
contribution mechanism too.
The major thing needs to improve before we think about graduation.
Justin Mclean <jm...@apache.org>于2019年9月5日 周四下午2:22写道：
> Hi,
>
> > And we can discuss how many pull requests is necessary for elect.
>
> And contribution can be for things other than code or PRs.
>
> Thanks,
> Justin
>
--
Sheng Wu
SkyWalking, Shardingsphere and Zipkin
Re: Talk about how to set committer bar
Posted by Justin Mclean <jm...@apache.org>.
Hi,
> And we can discuss how many pull requests is necessary for elect.
And contribution can be for things other than code or PRs.
Thanks,
Justin
Re: Talk about how to set committer bar
Posted by "zhangliang@apache.org" <zh...@apache.org>.
How about change `Make contributions consistently during the past 6 months`
to `Submit 5 quality pull requests`?
And we can discuss how many pull requests is necessary for elect.
------------------
Liang Zhang (John)
Apache ShardingSphere & Dubbo
Zheng Feng <zh...@gmail.com> 于2019年9月5日周四 下午9:57写道：
> I agree with Justin that we vote the committers more often.
>
> Justin Mclean <jm...@apache.org> 于2019年9月5日周四 下午9:46写道：
>
> > Hi,
> >
> > > 1. Make contributions consistently during the past 6 months
> > > 2. Understand the core technology of ShardingSphere deeply
> > > 3. Obey the Code of Conduct
> > > 4. Submit high-quality content
> > > 5. Enable Google Two-factor authentication
> >
> > While each PPMC/PMC can set their own bar this is far too high IMO, in
> > particular expecting someone to continually contribute for 6 months. Some
> > project votes in committers after two or three contributions.
> >
> > Thanks,
> > Justin
> >
>
Re: Talk about how to set committer bar
Posted by Zheng Feng <zh...@gmail.com>.
I agree with Justin that we vote the committers more often.
Justin Mclean <jm...@apache.org> 于2019年9月5日周四 下午9:46写道：
> Hi,
>
> > 1. Make contributions consistently during the past 6 months
> > 2. Understand the core technology of ShardingSphere deeply
> > 3. Obey the Code of Conduct
> > 4. Submit high-quality content
> > 5. Enable Google Two-factor authentication
>
> While each PPMC/PMC can set their own bar this is far too high IMO, in
> particular expecting someone to continually contribute for 6 months. Some
> project votes in committers after two or three contributions.
>
> Thanks,
> Justin
>
Re: Talk about how to set committer bar
Posted by Justin Mclean <jm...@apache.org>.
Hi,
> 1. Make contributions consistently during the past 6 months
> 2. Understand the core technology of ShardingSphere deeply
> 3. Obey the Code of Conduct
> 4. Submit high-quality content
> 5. Enable Google Two-factor authentication
While each PPMC/PMC can set their own bar this is far too high IMO, in particular expecting someone to continually contribute for 6 months. Some project votes in committers after two or three contributions.
Thanks,
Justin
Re: Talk about how to set committer bar
Posted by Zheng Feng <zh...@gmail.com>.
Why we need the 5. Enable Google Tow-factor authentication ?
zhangliang@apache.org <zh...@apache.org> 于2019年9月5日周四 下午9:29写道：
> Hi ShardingSphere community,
>
> There are 64 contributors for ShardingSphere, I want discuss about elected
> more committers.
>
> How to set committer bar? The previous rules can find here[1], they are:
>
>
> 1. Make contributions consistently during the past 6 months
> 2. Understand the core technology of ShardingSphere deeply
> 3. Obey the Code of Conduct
> 4. Submit high-quality content
> 5. Enable Google Two-factor authentication
>
> The committer bar perhaps too high for new committers, can we define some
> new rule to elect more committers?
>
> [1] https://shardingsphere.apache.org/community/en/contribute/committer/
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
Re: Talk about how to set committer bar
Posted by Sheng Wu <wu...@gmail.com>.
I would suggest that. Attracting new contributors and committers is our
highest priority to us today.
Sheng
zhangliang@apache.org <zh...@apache.org>于2019年9月10日 周二上午10:02写道：
> How about just remove this page from the website?
>
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
>
> Sheng Wu <wu...@gmail.com> 于2019年9月10日周二 上午12:19写道：
>
> > Again.
> > I don't like the static and strict rules for either committer or PPMC.
> > Consider my as -0 to this.
> >
> > Sheng Wu 吴晟
> >
> > Apache SkyWalking
> > Apache Incubator
> > Apache ShardingSphere, ECharts, DolphinScheduler podlings
> > Zipkin
> > Twitter, wusheng1108
> >
> >
> > zhangliang@apache.org <zh...@apache.org> 于2019年9月10日周二 上午12:15写道：
> >
> > > The draft of voting Committer and PPMC:
> > >
> > >
> > >
> > > ## Becoming a Committer
> > >
> > >
> > > - Make several pull requests (pull requests should exclude just fix a
> > > typo
> > > )
> > >
> > > - Participate discussion with community actively, include issue on
> > GitHub
> > > and apache mailing list
> > >
> > > - Participate contribution with other way, including but not limited
> to
> > > testing, documentation, translation, article publishing, representation
> > on
> > > conference and so on.
> > >
> > > - Satisfied one of conditions above, PPMC will start to discussion
> and
> > > voting qualified person to committer.
> > >
> > >
> > > ## Becoming a PPMC
> > >
> > >
> > > - Be a committer of ShardingSphere
> > >
> > > - Make contributions consistently during the past 6 months
> > >
> > > - Understand the core technology of ShardingSphere deeply
> > >
> > > - Obey the Code of Conduct and can submit high-quality pull requests
> > >
> > > - Do apache release at least once
> > >
> > > - Satisfied all of conditions above, PPMC will start to discussion
> and
> > > voting qualified person to PPMC.
> > >
> > >
> > > ------------------
> > >
> > > Liang Zhang (John)
> > > Apache ShardingSphere & Dubbo
> > >
> >
>
--
Sheng Wu
SkyWalking, Shardingsphere and Zipkin
Re: Talk about how to set committer bar
Posted by "zhangliang@apache.org" <zh...@apache.org>.
How about just remove this page from the website?
------------------
Liang Zhang (John)
Apache ShardingSphere & Dubbo
Sheng Wu <wu...@gmail.com> 于2019年9月10日周二 上午12:19写道：
> Again.
> I don't like the static and strict rules for either committer or PPMC.
> Consider my as -0 to this.
>
> Sheng Wu 吴晟
>
> Apache SkyWalking
> Apache Incubator
> Apache ShardingSphere, ECharts, DolphinScheduler podlings
> Zipkin
> Twitter, wusheng1108
>
>
> zhangliang@apache.org <zh...@apache.org> 于2019年9月10日周二 上午12:15写道：
>
> > The draft of voting Committer and PPMC:
> >
> >
> >
> > ## Becoming a Committer
> >
> >
> > - Make several pull requests (pull requests should exclude just fix a
> > typo
> > )
> >
> > - Participate discussion with community actively, include issue on
> GitHub
> > and apache mailing list
> >
> > - Participate contribution with other way, including but not limited to
> > testing, documentation, translation, article publishing, representation
> on
> > conference and so on.
> >
> > - Satisfied one of conditions above, PPMC will start to discussion and
> > voting qualified person to committer.
> >
> >
> > ## Becoming a PPMC
> >
> >
> > - Be a committer of ShardingSphere
> >
> > - Make contributions consistently during the past 6 months
> >
> > - Understand the core technology of ShardingSphere deeply
> >
> > - Obey the Code of Conduct and can submit high-quality pull requests
> >
> > - Do apache release at least once
> >
> > - Satisfied all of conditions above, PPMC will start to discussion and
> > voting qualified person to PPMC.
> >
> >
> > ------------------
> >
> > Liang Zhang (John)
> > Apache ShardingSphere & Dubbo
> >
>
Re: Talk about how to set committer bar
Posted by Sheng Wu <wu...@gmail.com>.
Again.
I don't like the static and strict rules for either committer or PPMC.
Consider my as -0 to this.
Sheng Wu 吴晟
Apache SkyWalking
Apache Incubator
Apache ShardingSphere, ECharts, DolphinScheduler podlings
Zipkin
Twitter, wusheng1108
zhangliang@apache.org <zh...@apache.org> 于2019年9月10日周二 上午12:15写道：
> The draft of voting Committer and PPMC:
>
>
>
> ## Becoming a Committer
>
>
> - Make several pull requests (pull requests should exclude just fix a
> typo
> )
>
> - Participate discussion with community actively, include issue on GitHub
> and apache mailing list
>
> - Participate contribution with other way, including but not limited to
> testing, documentation, translation, article publishing, representation on
> conference and so on.
>
> - Satisfied one of conditions above, PPMC will start to discussion and
> voting qualified person to committer.
>
>
> ## Becoming a PPMC
>
>
> - Be a committer of ShardingSphere
>
> - Make contributions consistently during the past 6 months
>
> - Understand the core technology of ShardingSphere deeply
>
> - Obey the Code of Conduct and can submit high-quality pull requests
>
> - Do apache release at least once
>
> - Satisfied all of conditions above, PPMC will start to discussion and
> voting qualified person to PPMC.
>
>
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
Re: Talk about how to set committer bar
Posted by "zhangliang@apache.org" <zh...@apache.org>.
The draft of voting Committer and PPMC:
## Becoming a Committer
- Make several pull requests (pull requests should exclude just fix a typo
)
- Participate discussion with community actively, include issue on GitHub
and apache mailing list
- Participate contribution with other way, including but not limited to
testing, documentation, translation, article publishing, representation on
conference and so on.
- Satisfied one of conditions above, PPMC will start to discussion and
voting qualified person to committer.
## Becoming a PPMC
- Be a committer of ShardingSphere
- Make contributions consistently during the past 6 months
- Understand the core technology of ShardingSphere deeply
- Obey the Code of Conduct and can submit high-quality pull requests
- Do apache release at least once
- Satisfied all of conditions above, PPMC will start to discussion and
voting qualified person to PPMC.
------------------
Liang Zhang (John)
Apache ShardingSphere & Dubbo
Re: Talk about how to set committer bar
Posted by Juan Pan <pa...@apache.org>.
Agree with William and Sheng.
Dynamic and not tight rules will attract more participants to contribute.
If he or she can show their commitment to community, we can invite them.
Actually, after browsing the Issues and Prs currently in community, i think
there are some participants who we can invite as commiters.
Hope community will be more prosperous.
---------------------------------
Juan Pan (Trista)
Apache ShardingSphere
zhangliang@apache.org <zh...@apache.org> 于2019年9月5日周四 下午9:29写道：
> Hi ShardingSphere community,
>
> There are 64 contributors for ShardingSphere, I want discuss about elected
> more committers.
>
> How to set committer bar? The previous rules can find here[1], they are:
>
>
> 1. Make contributions consistently during the past 6 months
> 2. Understand the core technology of ShardingSphere deeply
> 3. Obey the Code of Conduct
> 4. Submit high-quality content
> 5. Enable Google Two-factor authentication
>
> The committer bar perhaps too high for new committers, can we define some
> new rule to elect more committers?
>
> [1] https://shardingsphere.apache.org/community/en/contribute/committer/
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
Re: Talk about how to set committer bar
Posted by 苏仕祥 <sh...@qq.com>.
So the contributions someone makes is ambiguous.I just mention that thing.
But whatever,the community will know who makes contributions.
In conclusion,I approve the rules.
---Original---
From: "zhangliang@apache.org"<zhangliang@apache.org>
Date: Fri, Sep 6, 2019 19:54 PM
To: "dev"<dev@shardingsphere.apache.org>;
Subject: Re: Talk about how to set committer bar
Because way of contributions are diversity, so do we really need a clear
rule for voting, or just start to vote if some PPMCs think a contributor
could be prompt as a committer?
------------------
Liang Zhang (John)
Apache ShardingSphere & Dubbo
苏仕祥 <shixiangsu@qq.com> 于2019年9月6日周五 下午4:40写道：
> I agree with the rules.
>
>
> But the question is ,such as rule 3, we may not have effect method to
> meature how much contributions someone makes.
>
>
> lulu
>
>
> ------------------ 原始邮件 ------------------
> 发件人: "zhangliang@apache.org"<zhangliang@apache.org>;
> 发送时间: 2019年9月6日(星期五) 上午10:49
> 收件人: "dev"<dev@shardingsphere.apache.org>;
>
> 主题: Re: Talk about how to set committer bar
>
>
>
> Ok, we can set the committer bar more dynamic for different stage.
>
> Right now, the rules may include:
>
> 1. Contribute codes, contributor may contribute several pull requests.
> 2. Answer questions and participant discussion on Github and mailing list
> actively.
> 3. Other things for participant and contribute for community, such as talk
> about the project in public conf/event, publish articles and so on.
>
> Any thing else?
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
>
> Justin Mclean <jmclean@apache.org> 于2019年9月6日周五 上午10:20写道：
>
> > Hi,
> >
> > Again each project is different and sets their own committer bar, but I
> > wouldn't worry so much about the PR being perfect either, they can always
> > be fixed and improved. By setting the quality bar too high people may not
> > contribute because they don't think this code is good enough, even when
> > it's a good idea that would improved the code base.
> >
> > Thanks,
> > Justin
> >
Re: Talk about how to set committer bar
Posted by Sheng Wu <wu...@gmail.com>.
Commitments to a community is recognized by humand, ppmc. Really, don't set
a static rules, if the man makes you trusted, then at least invite him as
committer.
Static rule in this part makes contributor feeling like chasing a kpi.
Personal, don't like this.
Sheng
zhangliang@apache.org <zh...@apache.org>于2019年9月6日 周五上午4:54写道：
> Because way of contributions are diversity, so do we really need a clear
> rule for voting, or just start to vote if some PPMCs think a contributor
> could be prompt as a committer?
>
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
>
> 苏仕祥 <sh...@qq.com> 于2019年9月6日周五 下午4:40写道：
>
> > I agree with the rules.
> >
> >
> > But the question is ,such as rule 3, we may not have effect method to
> > meature how much contributions someone makes.
> >
> >
> > lulu
> >
> >
> > ------------------ 原始邮件 ------------------
> > 发件人: "zhangliang@apache.org"<zh...@apache.org>;
> > 发送时间: 2019年9月6日(星期五) 上午10:49
> > 收件人: "dev"<de...@shardingsphere.apache.org>;
> >
> > 主题: Re: Talk about how to set committer bar
> >
> >
> >
> > Ok, we can set the committer bar more dynamic for different stage.
> >
> > Right now, the rules may include:
> >
> > 1. Contribute codes, contributor may contribute several pull requests.
> > 2. Answer questions and participant discussion on Github and mailing list
> > actively.
> > 3. Other things for participant and contribute for community, such as
> talk
> > about the project in public conf/event, publish articles and so on.
> >
> > Any thing else?
> > ------------------
> >
> > Liang Zhang (John)
> > Apache ShardingSphere & Dubbo
> >
> >
> > Justin Mclean <jm...@apache.org> 于2019年9月6日周五 上午10:20写道：
> >
> > > Hi,
> > >
> > > Again each project is different and sets their own committer bar, but I
> > > wouldn't worry so much about the PR being perfect either, they can
> always
> > > be fixed and improved. By setting the quality bar too high people may
> not
> > > contribute because they don't think this code is good enough, even when
> > > it's a good idea that would improved the code base.
> > >
> > > Thanks,
> > > Justin
> > >
>
--
Sheng Wu
SkyWalking, Shardingsphere and Zipkin
Re: Talk about how to set committer bar
Posted by "zhangliang@apache.org" <zh...@apache.org>.
Because way of contributions are diversity, so do we really need a clear
rule for voting, or just start to vote if some PPMCs think a contributor
could be prompt as a committer?
------------------
Liang Zhang (John)
Apache ShardingSphere & Dubbo
苏仕祥 <sh...@qq.com> 于2019年9月6日周五 下午4:40写道：
> I agree with the rules.
>
>
> But the question is ,such as rule 3, we may not have effect method to
> meature how much contributions someone makes.
>
>
> lulu
>
>
> ------------------ 原始邮件 ------------------
> 发件人: "zhangliang@apache.org"<zh...@apache.org>;
> 发送时间: 2019年9月6日(星期五) 上午10:49
> 收件人: "dev"<de...@shardingsphere.apache.org>;
>
> 主题: Re: Talk about how to set committer bar
>
>
>
> Ok, we can set the committer bar more dynamic for different stage.
>
> Right now, the rules may include:
>
> 1. Contribute codes, contributor may contribute several pull requests.
> 2. Answer questions and participant discussion on Github and mailing list
> actively.
> 3. Other things for participant and contribute for community, such as talk
> about the project in public conf/event, publish articles and so on.
>
> Any thing else?
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
>
> Justin Mclean <jm...@apache.org> 于2019年9月6日周五 上午10:20写道：
>
> > Hi,
> >
> > Again each project is different and sets their own committer bar, but I
> > wouldn't worry so much about the PR being perfect either, they can always
> > be fixed and improved. By setting the quality bar too high people may not
> > contribute because they don't think this code is good enough, even when
> > it's a good idea that would improved the code base.
> >
> > Thanks,
> > Justin
> >
回复： Talk about how to set committer bar
Posted by 苏仕祥 <sh...@qq.com>.
I agree with the rules.
But the question is ,such as rule 3, we may not have effect method to meature how much contributions someone makes.
lulu
------------------ 原始邮件 ------------------
发件人: "zhangliang@apache.org"<zh...@apache.org>;
发送时间: 2019年9月6日(星期五) 上午10:49
收件人: "dev"<de...@shardingsphere.apache.org>;
主题: Re: Talk about how to set committer bar
Ok, we can set the committer bar more dynamic for different stage.
Right now, the rules may include:
1. Contribute codes, contributor may contribute several pull requests.
2. Answer questions and participant discussion on Github and mailing list
actively.
3. Other things for participant and contribute for community, such as talk
about the project in public conf/event, publish articles and so on.
Any thing else?
------------------
Liang Zhang (John)
Apache ShardingSphere & Dubbo
Justin Mclean <jm...@apache.org> 于2019年9月6日周五 上午10:20写道：
> Hi,
>
> Again each project is different and sets their own committer bar, but I
> wouldn't worry so much about the PR being perfect either, they can always
> be fixed and improved. By setting the quality bar too high people may not
> contribute because they don't think this code is good enough, even when
> it's a good idea that would improved the code base.
>
> Thanks,
> Justin
>
Re: Talk about how to set committer bar
Posted by Justin Mclean <jm...@apache.org>.
Hi,
There are many ways someone can contribute, writing documentation or tests, helping users, reviewing release candidates, cleaning up the website etc etc it's not just code.
Thanks,
Justin
Re: Talk about how to set committer bar
Posted by "zhangliang@apache.org" <zh...@apache.org>.
Ok, we can set the committer bar more dynamic for different stage.
Right now, the rules may include:
1. Contribute codes, contributor may contribute several pull requests.
2. Answer questions and participant discussion on Github and mailing list
actively.
3. Other things for participant and contribute for community, such as talk
about the project in public conf/event, publish articles and so on.
Any thing else?
------------------
Liang Zhang (John)
Apache ShardingSphere & Dubbo
Justin Mclean <jm...@apache.org> 于2019年9月6日周五 上午10:20写道：
> Hi,
>
> Again each project is different and sets their own committer bar, but I
> wouldn't worry so much about the PR being perfect either, they can always
> be fixed and improved. By setting the quality bar too high people may not
> contribute because they don't think this code is good enough, even when
> it's a good idea that would improved the code base.
>
> Thanks,
> Justin
>
Re: Talk about how to set committer bar
Posted by Justin Mclean <jm...@apache.org>.
Hi,
Again each project is different and sets their own committer bar, but I wouldn't worry so much about the PR being perfect either, they can always be fixed and improved. By setting the quality bar too high people may not contribute because they don't think this code is good enough, even when it's a good idea that would improved the code base.
Thanks,
Justin