You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/10 17:55:28 UTC
[GitHub] [incubator-superset] villebro commented on a change in pull request #11199: feat: add ECharts BoxPlot chart
villebro commented on a change in pull request #11199:
URL: https://github.com/apache/incubator-superset/pull/11199#discussion_r520758737
##########
File path: superset-frontend/cypress-base/cypress/integration/explore/AdhocFilters.test.ts
##########
@@ -23,11 +23,11 @@ describe('AdhocFilters', () => {
cy.route('GET', '/superset/explore_json/**').as('getJson');
cy.route('POST', '/superset/explore_json/**').as('postJson');
cy.route('GET', '/superset/filter/table/*/name').as('filterValues');
- });
-
- it('Should not load mathjs when not needed', () => {
cy.visitChartByName('Boys'); // a table chart
cy.verifySliceSuccess({ waitAlias: '@postJson' });
+ });
+
+ xit('Should not load mathjs when not needed', () => {
Review comment:
@ktmud I had to disable this, as apparently the function annotation layer that was added to the ECharts Timeseries viz loads `mathjs` despite not being used here. The relevant code is here (is called by `transformProps.ts`): https://github.com/apache-superset/superset-ui/blob/master/plugins/plugin-chart-echarts/src/utils/annotation.ts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org