[GitHub] [flink] sjwiesman edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough

[GitBox <gi...@apache.org>]

sjwiesman edited a comment on issue #8903: [FLINK-12747][docs] Getting Started - Table API Example Walkthrough
URL: https://github.com/apache/flink/pull/8903#issuecomment-510909640
 
 
   @morsapaes I believe I've addressed all of your comments
   
   @knaufk ~I'm working on adding testing to the archetypes, in particular the quickstarts have [archetype integration tests](https://maven.apache.org/archetype/maven-archetype-plugin/integration-test-mojo.html) but it doesn't seem like they actually run and that the quickstarts are covered by end to end tests. I am working to see if I can get the plugin to work since it is much lighter weight but worst case I will add the e2e tests.~ I've added e2e tests that check the walkthroughs compile and run. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services