[jira] [Created] (RANGER-796) Good coding practice: fix issues in updates from RANGER-794

["Madhan Neethiraj (JIRA)" <ji...@apache.org>]

Madhan Neethiraj created RANGER-796:
---------------------------------------

             Summary: Good coding practice: fix issues in updates from RANGER-794
                 Key: RANGER-796
                 URL: https://issues.apache.org/jira/browse/RANGER-796
             Project: Ranger
          Issue Type: Bug
    Affects Versions: 0.6.0
            Reporter: Madhan Neethiraj
            Assignee: Abhay Kulkarni


1) ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java: 124
  Unwritten public or protected field: org.apache.ranger.policyengine.PerfTestClient$RequestData.request

2) ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java: 136
  Unused public or protected field: org.apache.ranger.policyengine.PerfTestClient$RequestData.name

3) ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java: 136 
  Unused public or protected field: org.apache.ranger.policyengine.PerfTestClient$RequestData.result

4) ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java: 136
  Should org.apache.ranger.policyengine.PerfTestClient$RequestData be a _static_ inner class?

5) agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java: 92
  Should org.apache.ranger.plugin.util.PerfDataRecorder$PerfStatistic be a _static_ inner class?

6) ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerPolicyenginePerfTester.java: 134
  Catching RuntimeExceptions, perhaps unintentionally, with a catch block for Exception

7) agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java: 134
  Catching RuntimeExceptions, perhaps unintentionally, with a catch block for Exception

8) ranger-tools/src/main/java/org/apache/ranger/policyengine/CommandLineParser.java: 273
  org.apache.ranger.policyengine.CommandLineParser.showUsage(int) invokes System.exit(...), which shuts down the entire virtual machine.

9) ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java: 63
  reliance on default encoding: new java.io.InputStreamReader(InputStream)

10) ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java: 87
  reliance on default encoding: new java.io.InputStreamReader(InputStream)

11) agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java: 122
  reliance on default encoding: new java.io.InputStreamReader(InputStream)

12) ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java: 108
  Dead local store: result

13) agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java: 92
  Dead local store



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)