You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Avery Ching <av...@gmail.com> on 2013/05/13 22:24:20 UTC
Review Request: GIRAPH-666 : Netty execs threads and metrics threads don't
get cleaned up properly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11107/
-----------------------------------------------------------
Review request for giraph.
Description
-------
Cleans up our leaking threads.
This addresses bug GIRAPH-666.
https://issues.apache.org/jira/browse/GIRAPH-666
Diffs
-----
giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java 30c32fda8cdd588167231238ac994e475953bbc6
giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyServer.java 0bfc2d65955c75181d3b3c833e5ca5ca84f47567
giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 9caf1b9eed82c351d25cc2d760bfe7e40cc8bcc6
giraph-core/src/main/java/org/apache/giraph/metrics/GiraphMetrics.java 0454a5e3cbbc34f17166f361f4e65ad979d0ba3b
giraph-core/src/main/java/org/apache/giraph/metrics/GiraphMetricsRegistry.java 3c61872821524329e96980a2e24242b606503a76
Diff: https://reviews.apache.org/r/11107/diff/
Testing
-------
mvn clean verify
Before - https://issues.apache.org/jira/secure/attachment/12582979/Screen%20Shot%202013-05-13%20at%2012.44.11%20PM.png
After - https://issues.apache.org/jira/secure/attachment/12582978/Screen%20Shot%202013-05-13%20at%2012.42.45%20PM.png
Thanks,
Avery Ching
Re: Review Request: GIRAPH-666 : Netty execs threads and metrics threads
don't get cleaned up properly
Posted by Maja Kabiljo <ma...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11107/#review20502
-----------------------------------------------------------
Ship it!
Good find, +1!
- Maja Kabiljo
On May 13, 2013, 8:24 p.m., Avery Ching wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11107/
> -----------------------------------------------------------
>
> (Updated May 13, 2013, 8:24 p.m.)
>
>
> Review request for giraph.
>
>
> Description
> -------
>
> Cleans up our leaking threads.
>
>
> This addresses bug GIRAPH-666.
> https://issues.apache.org/jira/browse/GIRAPH-666
>
>
> Diffs
> -----
>
> giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java 30c32fda8cdd588167231238ac994e475953bbc6
> giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyServer.java 0bfc2d65955c75181d3b3c833e5ca5ca84f47567
> giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 9caf1b9eed82c351d25cc2d760bfe7e40cc8bcc6
> giraph-core/src/main/java/org/apache/giraph/metrics/GiraphMetrics.java 0454a5e3cbbc34f17166f361f4e65ad979d0ba3b
> giraph-core/src/main/java/org/apache/giraph/metrics/GiraphMetricsRegistry.java 3c61872821524329e96980a2e24242b606503a76
>
> Diff: https://reviews.apache.org/r/11107/diff/
>
>
> Testing
> -------
>
> mvn clean verify
> Before - https://issues.apache.org/jira/secure/attachment/12582979/Screen%20Shot%202013-05-13%20at%2012.44.11%20PM.png
> After - https://issues.apache.org/jira/secure/attachment/12582978/Screen%20Shot%202013-05-13%20at%2012.42.45%20PM.png
>
>
> Thanks,
>
> Avery Ching
>
>