You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/20 11:41:43 UTC
[GitHub] [spark] yaooqinn opened a new pull request #28274: [SPARK-31498][SQL] Dump public static sql configurations through doc generation
yaooqinn opened a new pull request #28274:
URL: https://github.com/apache/spark/pull/28274
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Currently, only the non-static public SQL configurations are dump to public doc, we'd better also add those static public ones as the command `set -v`
This PR force call StaticSQLConf to buildStaticConf.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Fix missing SQL configurations in doc
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
NO
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
add unit test and verify locally to see if public static SQL conf is in `docs/sql-config.html`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
yaooqinn removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616499010
cc @cloud-fan @dongjoon-hyun @maropu @HyukjinKwon thanks for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r411340481
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala
##########
@@ -42,6 +42,8 @@ private[sql] object PythonSQLUtils {
def listSQLConfigs(): Array[(String, String, String, String)] = {
val conf = new SQLConf()
+ // Force to build StaticSQLConf, which is a little bit hacky here
+ conf.warehousePath
Review comment:
Also, I think we should separately document these static SQL configurations instead of mixing with runtime configurations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616951288
**[Test build #121562 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121562/testReport)** for PR 28274 at commit [`4fca3fd`](https://github.com/apache/spark/commit/4fca3fdb0205cf572c56967567b9492d6db84a37).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616501182
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r412092802
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala
##########
@@ -43,7 +43,14 @@ private[sql] object PythonSQLUtils {
def listSQLConfigs(): Array[(String, String, String, String)] = {
val conf = new SQLConf()
// Py4J doesn't seem to translate Seq well, so we convert to an Array.
- conf.getAllDefinedConfs.toArray
+ conf.getAllDefinedConfs.filterNot(p => SQLConf.staticConfKeys.contains(p._1)).toArray
+ }
+
+ def listStaticSQLConfigs(): Array[(String, String, String, String)] = {
+ val conf = new SQLConf()
+ // Force to build static SQL configurations
+ StaticSQLConf.WAREHOUSE_PATH.key -> ()
Review comment:
thanks, it works. there must be some wrong with my environment when I try this way last time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616994791
**[Test build #121562 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121562/testReport)** for PR 28274 at commit [`4fca3fd`](https://github.com/apache/spark/commit/4fca3fdb0205cf572c56967567b9492d6db84a37).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r412002396
##########
File path: docs/configuration.md
##########
@@ -2622,11 +2622,27 @@ Please refer to the [Security](security.html) page for available options on how
Spark subsystems.
-{% for static_file in site.static_files %}
- {% if static_file.name == 'generated-sql-configuration-table.html' %}
### Spark SQL
-{% include_relative generated-sql-configuration-table.html %}
+#### Runtime SQL Configuration
+
+Runtime SQL configurations inner-session, mutable Spark SQL configurations. They can be set and queried by SET commands and rest by RESET command, or by `SparkSession.conf`'s setter and getter methods.
Review comment:
`Runtime SQL configurations are per-session, mutable Spark SQL configurations.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617126826
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616982429
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r412005145
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala
##########
@@ -43,7 +43,14 @@ private[sql] object PythonSQLUtils {
def listSQLConfigs(): Array[(String, String, String, String)] = {
val conf = new SQLConf()
// Py4J doesn't seem to translate Seq well, so we convert to an Array.
- conf.getAllDefinedConfs.toArray
+ conf.getAllDefinedConfs.filterNot(p => SQLConf.staticConfKeys.contains(p._1)).toArray
+ }
+
+ def listStaticSQLConfigs(): Array[(String, String, String, String)] = {
+ val conf = new SQLConf()
+ // Force to build static SQL configurations
+ StaticSQLConf.WAREHOUSE_PATH.key -> ()
Review comment:
what's special about `WAREHOUSE_PATH`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616998537
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617114799
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r412894045
##########
File path: sql/gen-sql-config-docs.py
##########
@@ -114,11 +119,17 @@ def generate_sql_configs_table_html(sql_configs, path):
if __name__ == "__main__":
+ if len(sys.argv) != 2:
+ print("Usage: ./bin/spark-submit sql/gen-sql-config-docs.py <static|runtime>")
Review comment:
got it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r412897921
##########
File path: docs/configuration.md
##########
@@ -2622,11 +2622,32 @@ Please refer to the [Security](security.html) page for available options on how
Spark subsystems.
-{% for static_file in site.static_files %}
- {% if static_file.name == 'generated-sql-configuration-table.html' %}
### Spark SQL
-{% include_relative generated-sql-configuration-table.html %}
+#### Runtime SQL Configuration
+
+Runtime SQL configurations are per-session, mutable Spark SQL configurations. They can be set with initial values by the config file
+and command-line options with `--conf/-c` prefixed, or by setting `SparkConf` that are used to create `SparkSession`.
+Also, they can be set and queried by SET commands and rest to their initial values by RESET command,
+or by `SparkSession.conf`'s setter and getter methods in runtime.
+
+{% for static_file in site.static_files %}
+ {% if static_file.name == 'generated-runtime-sql-config-table.html' %}
+ {% include_relative generated-runtime-sql-config-table.html %}
Review comment:
Might the problem be `### Spark SQL` content is inside the for-loop before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617242334
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617218280
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616970639
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617079128
**[Test build #121572 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121572/testReport)** for PR 28274 at commit [`4fca3fd`](https://github.com/apache/spark/commit/4fca3fdb0205cf572c56967567b9492d6db84a37).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617080172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616951288
**[Test build #121562 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121562/testReport)** for PR 28274 at commit [`4fca3fd`](https://github.com/apache/spark/commit/4fca3fdb0205cf572c56967567b9492d6db84a37).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616995252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r412894905
##########
File path: docs/configuration.md
##########
@@ -2622,11 +2622,32 @@ Please refer to the [Security](security.html) page for available options on how
Spark subsystems.
-{% for static_file in site.static_files %}
- {% if static_file.name == 'generated-sql-configuration-table.html' %}
### Spark SQL
-{% include_relative generated-sql-configuration-table.html %}
+#### Runtime SQL Configuration
+
+Runtime SQL configurations are per-session, mutable Spark SQL configurations. They can be set with initial values by the config file
+and command-line options with `--conf/-c` prefixed, or by setting `SparkConf` that are used to create `SparkSession`.
+Also, they can be set and queried by SET commands and rest to their initial values by RESET command,
+or by `SparkSession.conf`'s setter and getter methods in runtime.
+
+{% for static_file in site.static_files %}
+ {% if static_file.name == 'generated-runtime-sql-config-table.html' %}
+ {% include_relative generated-runtime-sql-config-table.html %}
Review comment:
I intentionally removed the leading spaces here because they are considered actual white spaces. Newer liquid syntax supports to ignore these white spaces but I didn't use in case old Jykill is used.
Seems like it could make the html format malformed in some cases given my rough testing. Let's remove these leading white spaces next time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616671505
**[Test build #121539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121539/testReport)** for PR 28274 at commit [`991a7ec`](https://github.com/apache/spark/commit/991a7ecd8de3339feacede9af1e053e8f1673ce6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617126826
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r412895559
##########
File path: docs/configuration.md
##########
@@ -2622,11 +2622,32 @@ Please refer to the [Security](security.html) page for available options on how
Spark subsystems.
-{% for static_file in site.static_files %}
- {% if static_file.name == 'generated-sql-configuration-table.html' %}
### Spark SQL
-{% include_relative generated-sql-configuration-table.html %}
+#### Runtime SQL Configuration
+
+Runtime SQL configurations are per-session, mutable Spark SQL configurations. They can be set with initial values by the config file
+and command-line options with `--conf/-c` prefixed, or by setting `SparkConf` that are used to create `SparkSession`.
+Also, they can be set and queried by SET commands and rest to their initial values by RESET command,
+or by `SparkSession.conf`'s setter and getter methods in runtime.
+
+{% for static_file in site.static_files %}
+ {% if static_file.name == 'generated-runtime-sql-config-table.html' %}
+ {% include_relative generated-runtime-sql-config-table.html %}
+ {% break %}
+ {% endif %}
+{% endfor %}
+
+
+#### Static SQL Configuration
+
+Static SQL configurations are cross-session, immutable Spark SQL configurations. They can be set with final values by the config file
+and command-line options with `--conf/-c` prefixed, or by setting `SparkConf` that are used to create `SparkSession`.
Review comment:
You could mention `spark-default.conf` too, but it's okay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616498622
cc @cloud-fan @dongjoon-hyun @maropu @HyukjinKwon thanks for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617687618
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617242334
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616734649
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121539/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616982429
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616905435
**[Test build #121553 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121553/testReport)** for PR 28274 at commit [`284ab70`](https://github.com/apache/spark/commit/284ab7008a8cbb5f9df1d27652b4ad0b622c2395).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617114799
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r412950633
##########
File path: docs/configuration.md
##########
@@ -2622,11 +2622,32 @@ Please refer to the [Security](security.html) page for available options on how
Spark subsystems.
-{% for static_file in site.static_files %}
- {% if static_file.name == 'generated-sql-configuration-table.html' %}
### Spark SQL
-{% include_relative generated-sql-configuration-table.html %}
+#### Runtime SQL Configuration
+
+Runtime SQL configurations are per-session, mutable Spark SQL configurations. They can be set with initial values by the config file
+and command-line options with `--conf/-c` prefixed, or by setting `SparkConf` that are used to create `SparkSession`.
+Also, they can be set and queried by SET commands and rest to their initial values by RESET command,
+or by `SparkSession.conf`'s setter and getter methods in runtime.
+
+{% for static_file in site.static_files %}
+ {% if static_file.name == 'generated-runtime-sql-config-table.html' %}
+ {% include_relative generated-runtime-sql-config-table.html %}
Review comment:
No, we already use the markdown and Liquid syntax together at https://github.com/apache/spark/blob/master/docs/sql-ref-functions-builtin.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617217074
**[Test build #121582 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121582/testReport)** for PR 28274 at commit [`81e043f`](https://github.com/apache/spark/commit/81e043f592da25d03fe7674f00eeab9333a473a5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617123647
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616500568
**[Test build #121527 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121527/testReport)** for PR 28274 at commit [`9324ba9`](https://github.com/apache/spark/commit/9324ba9ef674aec857f6172c50a7290e3df5be71).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616903584
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616931482
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616995770
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617080172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617124889
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617066074
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616970639
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r412897921
##########
File path: docs/configuration.md
##########
@@ -2622,11 +2622,32 @@ Please refer to the [Security](security.html) page for available options on how
Spark subsystems.
-{% for static_file in site.static_files %}
- {% if static_file.name == 'generated-sql-configuration-table.html' %}
### Spark SQL
-{% include_relative generated-sql-configuration-table.html %}
+#### Runtime SQL Configuration
+
+Runtime SQL configurations are per-session, mutable Spark SQL configurations. They can be set with initial values by the config file
+and command-line options with `--conf/-c` prefixed, or by setting `SparkConf` that are used to create `SparkSession`.
+Also, they can be set and queried by SET commands and rest to their initial values by RESET command,
+or by `SparkSession.conf`'s setter and getter methods in runtime.
+
+{% for static_file in site.static_files %}
+ {% if static_file.name == 'generated-runtime-sql-config-table.html' %}
+ {% include_relative generated-runtime-sql-config-table.html %}
Review comment:
Might the problem be that `### Spark SQL` content is inside the for-loop before?
##########
File path: docs/configuration.md
##########
@@ -2622,11 +2622,32 @@ Please refer to the [Security](security.html) page for available options on how
Spark subsystems.
-{% for static_file in site.static_files %}
- {% if static_file.name == 'generated-sql-configuration-table.html' %}
### Spark SQL
-{% include_relative generated-sql-configuration-table.html %}
+#### Runtime SQL Configuration
+
+Runtime SQL configurations are per-session, mutable Spark SQL configurations. They can be set with initial values by the config file
+and command-line options with `--conf/-c` prefixed, or by setting `SparkConf` that are used to create `SparkSession`.
+Also, they can be set and queried by SET commands and rest to their initial values by RESET command,
+or by `SparkSession.conf`'s setter and getter methods in runtime.
+
+{% for static_file in site.static_files %}
+ {% if static_file.name == 'generated-runtime-sql-config-table.html' %}
+ {% include_relative generated-runtime-sql-config-table.html %}
Review comment:
Might the problem be that `### Spark SQL` content was inside the for-loop before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617240938
**[Test build #121583 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121583/testReport)** for PR 28274 at commit [`81e043f`](https://github.com/apache/spark/commit/81e043f592da25d03fe7674f00eeab9333a473a5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617114240
**[Test build #121582 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121582/testReport)** for PR 28274 at commit [`81e043f`](https://github.com/apache/spark/commit/81e043f592da25d03fe7674f00eeab9333a473a5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616997892
**[Test build #121572 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121572/testReport)** for PR 28274 at commit [`4fca3fd`](https://github.com/apache/spark/commit/4fca3fdb0205cf572c56967567b9492d6db84a37).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617126368
**[Test build #121583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121583/testReport)** for PR 28274 at commit [`81e043f`](https://github.com/apache/spark/commit/81e043f592da25d03fe7674f00eeab9333a473a5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616734646
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616671505
**[Test build #121539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121539/testReport)** for PR 28274 at commit [`991a7ec`](https://github.com/apache/spark/commit/991a7ecd8de3339feacede9af1e053e8f1673ce6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616931195
**[Test build #121559 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121559/testReport)** for PR 28274 at commit [`b61b46c`](https://github.com/apache/spark/commit/b61b46cc06dfc8f13a9164f5f3fd9584dcdbeb99).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616687141
**[Test build #121527 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121527/testReport)** for PR 28274 at commit [`9324ba9`](https://github.com/apache/spark/commit/9324ba9ef674aec857f6172c50a7290e3df5be71).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616734646
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616500568
**[Test build #121527 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121527/testReport)** for PR 28274 at commit [`9324ba9`](https://github.com/apache/spark/commit/9324ba9ef674aec857f6172c50a7290e3df5be71).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r411353662
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala
##########
@@ -42,6 +42,8 @@ private[sql] object PythonSQLUtils {
def listSQLConfigs(): Array[(String, String, String, String)] = {
val conf = new SQLConf()
+ // Force to build StaticSQLConf, which is a little bit hacky here
+ conf.warehousePath
Review comment:
OK, I agree. I didn't separate them because the command `set -v` doesn't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617065332
**[Test build #121580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121580/testReport)** for PR 28274 at commit [`1de696e`](https://github.com/apache/spark/commit/1de696e81f23361693519acc50a65f9870e6dea7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r412003598
##########
File path: docs/configuration.md
##########
@@ -2622,11 +2622,27 @@ Please refer to the [Security](security.html) page for available options on how
Spark subsystems.
-{% for static_file in site.static_files %}
- {% if static_file.name == 'generated-sql-configuration-table.html' %}
### Spark SQL
-{% include_relative generated-sql-configuration-table.html %}
+#### Runtime SQL Configuration
+
+Runtime SQL configurations inner-session, mutable Spark SQL configurations. They can be set and queried by SET commands and rest by RESET command, or by `SparkSession.conf`'s setter and getter methods.
+
+{% for static_file in site.static_files %}
+ {% if static_file.name == 'generated-runtime-sql-config-table.html' %}
+ {% include_relative generated-runtime-sql-config-table.html %}
+ {% break %}
+ {% endif %}
+{% endfor %}
+
+
+#### Static SQL Configuration
+
+Static SQL configurations are cross-session, immutable Spark SQL configurations. External users can query the static sql config values via `SparkSession.conf` or via set command, e.g. `SET spark.sql.extensions;`, but cannot set/unset them.
Review comment:
We should also mention how to set them, e.g. by config file or by setting `SparkConf` that is used to create `SparkSession`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r412893096
##########
File path: sql/gen-sql-config-docs.py
##########
@@ -114,11 +119,17 @@ def generate_sql_configs_table_html(sql_configs, path):
if __name__ == "__main__":
+ if len(sys.argv) != 2:
+ print("Usage: ./bin/spark-submit sql/gen-sql-config-docs.py <static|runtime>")
Review comment:
You could just call the function twice instead of adding an argument considering that SQL configuration gen is pretty cheap. Let's fix it next time when we happen to touch here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616734198
**[Test build #121539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121539/testReport)** for PR 28274 at commit [`991a7ec`](https://github.com/apache/spark/commit/991a7ecd8de3339feacede9af1e053e8f1673ce6).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616689058
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616995263
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121562/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616931195
**[Test build #121559 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121559/testReport)** for PR 28274 at commit [`b61b46c`](https://github.com/apache/spark/commit/b61b46cc06dfc8f13a9164f5f3fd9584dcdbeb99).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616969597
**[Test build #121553 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121553/testReport)** for PR 28274 at commit [`284ab70`](https://github.com/apache/spark/commit/284ab7008a8cbb5f9df1d27652b4ad0b622c2395).
* This patch passes all tests.
* This patch **does not merge cleanly**.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617122976
**[Test build #121580 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121580/testReport)** for PR 28274 at commit [`1de696e`](https://github.com/apache/spark/commit/1de696e81f23361693519acc50a65f9870e6dea7).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616997892
**[Test build #121572 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121572/testReport)** for PR 28274 at commit [`4fca3fd`](https://github.com/apache/spark/commit/4fca3fdb0205cf572c56967567b9492d6db84a37).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r412007203
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala
##########
@@ -43,7 +43,14 @@ private[sql] object PythonSQLUtils {
def listSQLConfigs(): Array[(String, String, String, String)] = {
val conf = new SQLConf()
// Py4J doesn't seem to translate Seq well, so we convert to an Array.
- conf.getAllDefinedConfs.toArray
+ conf.getAllDefinedConfs.filterNot(p => SQLConf.staticConfKeys.contains(p._1)).toArray
+ }
+
+ def listStaticSQLConfigs(): Array[(String, String, String, String)] = {
+ val conf = new SQLConf()
+ // Force to build static SQL configurations
+ StaticSQLConf.WAREHOUSE_PATH.key -> ()
Review comment:
Nothing special, just find something to invoke? Couldn't find another proper way to build static ones to SQLConf, any advice?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616501182
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r411347467
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala
##########
@@ -42,6 +42,8 @@ private[sql] object PythonSQLUtils {
def listSQLConfigs(): Array[(String, String, String, String)] = {
val conf = new SQLConf()
+ // Force to build StaticSQLConf, which is a little bit hacky here
+ conf.warehousePath
Review comment:
+1 on the idea to separately document them. Putting them in the same table looks confusing...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616981822
**[Test build #121559 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121559/testReport)** for PR 28274 at commit [`b61b46c`](https://github.com/apache/spark/commit/b61b46cc06dfc8f13a9164f5f3fd9584dcdbeb99).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r412899438
##########
File path: docs/configuration.md
##########
@@ -2622,11 +2622,32 @@ Please refer to the [Security](security.html) page for available options on how
Spark subsystems.
-{% for static_file in site.static_files %}
- {% if static_file.name == 'generated-sql-configuration-table.html' %}
### Spark SQL
-{% include_relative generated-sql-configuration-table.html %}
+#### Runtime SQL Configuration
+
+Runtime SQL configurations are per-session, mutable Spark SQL configurations. They can be set with initial values by the config file
+and command-line options with `--conf/-c` prefixed, or by setting `SparkConf` that are used to create `SparkSession`.
+Also, they can be set and queried by SET commands and rest to their initial values by RESET command,
+or by `SparkSession.conf`'s setter and getter methods in runtime.
+
+{% for static_file in site.static_files %}
+ {% if static_file.name == 'generated-runtime-sql-config-table.html' %}
+ {% include_relative generated-runtime-sql-config-table.html %}
+ {% break %}
+ {% endif %}
+{% endfor %}
+
+
+#### Static SQL Configuration
+
+Static SQL configurations are cross-session, immutable Spark SQL configurations. They can be set with final values by the config file
+and command-line options with `--conf/-c` prefixed, or by setting `SparkConf` that are used to create `SparkSession`.
Review comment:
`by the config file` might have the same meaning but it could be better if we use `spark-default.conf`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r412062680
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala
##########
@@ -43,7 +43,14 @@ private[sql] object PythonSQLUtils {
def listSQLConfigs(): Array[(String, String, String, String)] = {
val conf = new SQLConf()
// Py4J doesn't seem to translate Seq well, so we convert to an Array.
- conf.getAllDefinedConfs.toArray
+ conf.getAllDefinedConfs.filterNot(p => SQLConf.staticConfKeys.contains(p._1)).toArray
+ }
+
+ def listStaticSQLConfigs(): Array[(String, String, String, String)] = {
+ val conf = new SQLConf()
+ // Force to build static SQL configurations
+ StaticSQLConf.WAREHOUSE_PATH.key -> ()
Review comment:
just write `StaticSQLConf` doesn't work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616998537
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617065332
**[Test build #121580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121580/testReport)** for PR 28274 at commit [`1de696e`](https://github.com/apache/spark/commit/1de696e81f23361693519acc50a65f9870e6dea7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617123682
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121580/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617126368
**[Test build #121583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121583/testReport)** for PR 28274 at commit [`81e043f`](https://github.com/apache/spark/commit/81e043f592da25d03fe7674f00eeab9333a473a5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616905435
**[Test build #121553 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121553/testReport)** for PR 28274 at commit [`284ab70`](https://github.com/apache/spark/commit/284ab7008a8cbb5f9df1d27652b4ad0b622c2395).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616949666
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617218280
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616949666
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616499010
cc @cloud-fan @dongjoon-hyun @maropu @HyukjinKwon thanks for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616982432
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121559/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617066074
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616689058
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616667909
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616903584
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28274:
URL: https://github.com/apache/spark/pull/28274#discussion_r411339218
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala
##########
@@ -42,6 +42,8 @@ private[sql] object PythonSQLUtils {
def listSQLConfigs(): Array[(String, String, String, String)] = {
val conf = new SQLConf()
+ // Force to build StaticSQLConf, which is a little bit hacky here
+ conf.warehousePath
Review comment:
Why don't you just reference `StaticSQLConf` directly here instead of `conf.warehousePath`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616667909
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617114240
**[Test build #121582 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121582/testReport)** for PR 28274 at commit [`81e043f`](https://github.com/apache/spark/commit/81e043f592da25d03fe7674f00eeab9333a473a5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-617123647
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616931482
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28274: [SPARK-31498][SQL][DOCS] Dump public static sql configurations through doc generation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616995252
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org