You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beehive.apache.org by ri...@apache.org on 2005/05/16 22:25:19 UTC

svn commit: r170443 - in /incubator/beehive/trunk/samples/netui-samples: Controller.java WEB-INF/web.xml ui/tree/Controller.java

Author: rich
Date: Mon May 16 13:25:19 2005
New Revision: 170443

URL: http://svn.apache.org/viewcvs?rev=170443&view=rev
Log:
Some minor cleanup in netui-samples, now that the JSF sample is moving back out of it.  This also includes the changes to netui-samples for http://issues.apache.org/jira/browse/BEEHIVE-736 -- should have committed that with revision 170267.


Modified:
    incubator/beehive/trunk/samples/netui-samples/Controller.java
    incubator/beehive/trunk/samples/netui-samples/WEB-INF/web.xml
    incubator/beehive/trunk/samples/netui-samples/ui/tree/Controller.java

Modified: incubator/beehive/trunk/samples/netui-samples/Controller.java
URL: http://svn.apache.org/viewcvs/incubator/beehive/trunk/samples/netui-samples/Controller.java?rev=170443&r1=170442&r2=170443&view=diff
==============================================================================
--- incubator/beehive/trunk/samples/netui-samples/Controller.java (original)
+++ incubator/beehive/trunk/samples/netui-samples/Controller.java Mon May 16 13:25:19 2005
@@ -15,7 +15,7 @@
  *
  * $Header:$
  */
- import javax.servlet.http.HttpSession;
+import javax.servlet.http.HttpSession;
 
 import org.apache.beehive.netui.pageflow.Forward;
 import org.apache.beehive.netui.pageflow.PageFlowController;

Modified: incubator/beehive/trunk/samples/netui-samples/WEB-INF/web.xml
URL: http://svn.apache.org/viewcvs/incubator/beehive/trunk/samples/netui-samples/WEB-INF/web.xml?rev=170443&r1=170442&r2=170443&view=diff
==============================================================================
--- incubator/beehive/trunk/samples/netui-samples/WEB-INF/web.xml (original)
+++ incubator/beehive/trunk/samples/netui-samples/WEB-INF/web.xml Mon May 16 13:25:19 2005
@@ -7,16 +7,34 @@
 
     <display-name>Beehive Web Application</display-name>
 
+    <!-- Filter to perform Page Flow operations when JSPs are hit directly. -->
     <filter>
         <filter-name>PageFlowJspFilter</filter-name>
         <filter-class>org.apache.beehive.netui.pageflow.PageFlowJspFilter</filter-class>
     </filter>
 
+    <!-- Filter to perform Page Flow operations when JavaServer Faces pages are hit directly. -->
     <filter>
         <filter-name>PageFlowFacesFilter</filter-name>
         <filter-class>org.apache.beehive.netui.pageflow.PageFlowFacesFilter</filter-class>
     </filter>
 
+    <!--
+        It is possible - but certainly not required - to keep source files such as page flows and
+        JavaServer Faces backing beans mixed in with web content.  In this case, and when the web
+        content directory itself is being deployed without being copied to some other build
+        location, it is important to prevent the source code from being URL-addressable.  This
+        filter returns a specified error code when source files are requested.
+    -->
+    <filter>
+        <filter-name>PageFlowForbiddenFilter</filter-name>
+        <filter-class>org.apache.beehive.netui.pageflow.PageFlowForbiddenFilter</filter-class>
+        <init-param>
+            <param-name>response-code</param-name>
+            <param-value>404</param-value>
+        </init-param>
+    </filter>
+
     <filter-mapping>
         <filter-name>PageFlowJspFilter</filter-name>
         <url-pattern>*.jsp</url-pattern>
@@ -49,6 +67,27 @@
         <dispatcher>INCLUDE</dispatcher>
     </filter-mapping>
 
+    <!-- Prevent URL access to Java source code. -->
+    <filter-mapping>
+        <filter-name>PageFlowForbiddenFilter</filter-name>
+        <url-pattern>*.java</url-pattern>
+        <dispatcher>REQUEST</dispatcher>
+    </filter-mapping>
+
+    <!-- Prevent URL access to JavaServer Faces backing beans.  -->
+    <filter-mapping>
+        <filter-name>PageFlowForbiddenFilter</filter-name>
+        <url-pattern>*.jsfb</url-pattern>
+        <dispatcher>REQUEST</dispatcher>
+    </filter-mapping>
+
+    <!-- Prevent URL access to shared flow source files.  -->
+    <filter-mapping>
+        <filter-name>PageFlowForbiddenFilter</filter-name>
+        <url-pattern>*.jpfs</url-pattern>
+        <dispatcher>REQUEST</dispatcher>
+    </filter-mapping>
+
     <!-- Action Servlet Configuration (with debugging) -->
     <servlet>
         <servlet-name>action</servlet-name>
@@ -84,16 +123,6 @@
 
     <servlet-mapping>
         <servlet-name>action</servlet-name>
-        <url-pattern>*.jpfs</url-pattern>
-    </servlet-mapping>
-
-    <servlet-mapping>
-        <servlet-name>action</servlet-name>
-        <url-pattern>*.jsfb</url-pattern>
-    </servlet-mapping>
-
-    <servlet-mapping>
-        <servlet-name>action</servlet-name>
         <url-pattern>*.do</url-pattern>
     </servlet-mapping>
 
@@ -106,5 +135,4 @@
     <welcome-file-list>
         <welcome-file>index.jsp</welcome-file>
     </welcome-file-list>
-
 </web-app>

Modified: incubator/beehive/trunk/samples/netui-samples/ui/tree/Controller.java
URL: http://svn.apache.org/viewcvs/incubator/beehive/trunk/samples/netui-samples/ui/tree/Controller.java?rev=170443&r1=170442&r2=170443&view=diff
==============================================================================
--- incubator/beehive/trunk/samples/netui-samples/ui/tree/Controller.java (original)
+++ incubator/beehive/trunk/samples/netui-samples/ui/tree/Controller.java Mon May 16 13:25:19 2005
@@ -27,10 +27,10 @@
 
 import javax.servlet.ServletRequest;
 import javax.servlet.http.HttpSession;
+
 import org.apache.beehive.netui.pageflow.Forward;
 
-@Jpf.Controller (
-)
+@Jpf.Controller()
 public class Controller extends PageFlowController
 {
     private TreeElement _root;