[GitHub] [druid] jihoonson commented on a change in pull request #11000: Fix auto compaction with mixed versions in the same time chunk based on new segment granularity

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #11000:
URL: https://github.com/apache/druid/pull/11000#discussion_r595461615



##########
File path: server/src/test/java/org/apache/druid/server/coordinator/duty/NewestSegmentFirstPolicyTest.java
##########
@@ -642,6 +642,33 @@ public void testIteratorDoesNotReturnCompactedInterval()
     Assert.assertFalse(iterator.hasNext());
   }
 
+  @Test
+  public void testIteratorReturnsAllMixedVersionSegmentsInConfiguredSegmentGranularity()
+  {
+    final VersionedIntervalTimeline<String, DataSegment> timeline = createTimeline(
+        new SegmentGenerateSpec(Intervals.of("2017-10-01T00:00:00/2017-10-02T00:00:00"), new Period("P1D"), "1994-04-29T00:00:00.000Z"),
+        new SegmentGenerateSpec(Intervals.of("2017-10-01T00:01:00/2017-10-01T00:02:00"), new Period("PT1H"), "1994-04-30T00:00:00.000Z")

Review comment:
       nit: do you want to fix the interval or the period as they mismatch?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org