You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "raiden00pl (via GitHub)" <gi...@apache.org> on 2023/07/25 19:16:00 UTC
[GitHub] [nuttx] raiden00pl opened a new pull request, #9897: cmake: add support to compile definitions for apps
raiden00pl opened a new pull request, #9897:
URL: https://github.com/apache/nuttx/pull/9897
## Summary
cmake: add support for compile definitions for apps
With this we can pass build options to compiled app which is useful for integrating external projects
## Impact
Example usage for Eclipse Wakaama client example (not yet upstream):
```
if(CONFIG_WAKAAMA_EXAMPLE_CLIENT)
nuttx_add_application(NAME
lwm2mclient
SRCS
${CLIENT_SOURCES}
STACKSIZE
4096
COMPILE_FLAGS
${WAKAAMA_OPTIONS}
DEFINITIONS
${WAKAAMA_DEFINITIONS})
target_sources_wakaama(apps_lwm2mclient)
target_sources_shared(apps_lwm2mclient)
endif()
```
## Testing
Eclipse Wakaama client example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] anchao commented on a diff in pull request #9897: cmake: add support to compile definitions for apps
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #9897:
URL: https://github.com/apache/nuttx/pull/9897#discussion_r1274285136
##########
cmake/nuttx_add_application.cmake:
##########
@@ -35,13 +35,14 @@ define_property(
#
# Usage: nuttx_add_application( NAME <string> [ PRIORITY <string> ] [ STACKSIZE
# <string> ] [ COMPILE_FLAGS <list> ] [ INCLUDE_DIRECTORIES <list> ] [ DEPENDS
-# <string> ] [ MODULE <string> ] [ SRCS <list> ] )
Review Comment:
It seems that the style of the comment is wrongly formatted in the check of cmake-format. could we consider using the comment fence to protect this part of the code?
https://github.com/cheshirekow/cmake_format/blob/master/cmakelang/doc/README.rst?plain=1#L239-L250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #9897: cmake: add support to compile definitions for apps
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #9897:
URL: https://github.com/apache/nuttx/pull/9897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] raiden00pl commented on a diff in pull request #9897: cmake: add support to compile definitions for apps
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on code in PR #9897:
URL: https://github.com/apache/nuttx/pull/9897#discussion_r1274399605
##########
cmake/nuttx_add_application.cmake:
##########
@@ -35,13 +35,14 @@ define_property(
#
# Usage: nuttx_add_application( NAME <string> [ PRIORITY <string> ] [ STACKSIZE
# <string> ] [ COMPILE_FLAGS <list> ] [ INCLUDE_DIRECTORIES <list> ] [ DEPENDS
-# <string> ] [ MODULE <string> ] [ SRCS <list> ] )
Review Comment:
Good idea, I reformatted the dockstring to be human readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org