You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Always-prog (via GitHub)" <gi...@apache.org> on 2023/07/25 13:08:38 UTC
[GitHub] [superset] Always-prog opened a new pull request, #24798: fix(chore): switching between languages should be without timeout 60 seconds
Always-prog opened a new pull request, #24798:
URL: https://github.com/apache/superset/pull/24798
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
This is a fix for the problem of switching between languages. Currently, Superset has a 60-second timeout when switching languages due to using a memoized function. I added the locale as a dependency for that memoized function.
CC @bkyryliuk (https://github.com/apache/superset/commit/44654e5abcc70d1fd934529dc82d7fe1d1bb20ef)
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
#### Before
https://github.com/apache/superset/assets/66589759/d0b43b3c-16e8-4c1c-9eec-efe911a18b7a
#### After
https://github.com/apache/superset/assets/66589759/d6ba6f8c-8d71-400d-aa13-569453939d30
### TESTING INSTRUCTIONS
1. Open Superset
2. Try to change the language twice
3. Notice that your second attempt doesn't changed language.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #23456
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #24798: fix(chore): switching between languages should be without timeout 60 seconds
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #24798:
URL: https://github.com/apache/superset/pull/24798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24798: fix(chore): switching between languages should be without timeout 60 seconds
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24798:
URL: https://github.com/apache/superset/pull/24798#issuecomment-1649827410
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24798?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24798](https://app.codecov.io/gh/apache/superset/pull/24798?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b1879c7) into [master](https://app.codecov.io/gh/apache/superset/commit/cb9b865a5398c479d221308ac6be1bd0a442f778?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cb9b865) will **decrease** coverage by `0.09%`.
> The diff coverage is `66.75%`.
> :exclamation: Current head b1879c7 differs from pull request most recent head ca4132d. Consider uploading reports for the commit ca4132d to get more accurate results
```diff
@@ Coverage Diff @@
## master #24798 +/- ##
==========================================
- Coverage 58.35% 58.27% -0.09%
==========================================
Files 1901 1902 +1
Lines 73933 73996 +63
Branches 8183 8195 +12
==========================================
- Hits 43146 43123 -23
- Misses 28666 28754 +88
+ Partials 2121 2119 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| presto | `54.06% <47.70%> (+<0.01%)` | :arrow_up: |
| python | `60.99% <61.92%> (-0.26%)` | :arrow_down: |
| unit | `54.95% <58.25%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/superset/pull/24798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...src/components/ColumnTypeLabel/ColumnTypeLabel.tsx](https://app.codecov.io/gh/apache/superset/pull/24798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsL0NvbHVtblR5cGVMYWJlbC50c3g=) | `100.00% <ø> (ø)` | |
| [...d/packages/superset-ui-chart-controls/src/index.ts](https://app.codecov.io/gh/apache/superset/pull/24798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2luZGV4LnRz) | `100.00% <ø> (ø)` | |
| [...-chart-controls/src/sections/advancedAnalytics.tsx](https://app.codecov.io/gh/apache/superset/pull/24798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NlY3Rpb25zL2FkdmFuY2VkQW5hbHl0aWNzLnRzeA==) | `14.28% <ø> (ø)` | |
| [...rset-ui-chart-controls/src/sections/chartTitle.tsx](https://app.codecov.io/gh/apache/superset/pull/24798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NlY3Rpb25zL2NoYXJ0VGl0bGUudHN4) | `100.00% <ø> (ø)` | |
| [...legacy-plugin-chart-partition/src/controlPanel.tsx](https://app.codecov.io/gh/apache/superset/pull/24798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvY29udHJvbFBhbmVsLnRzeA==) | `25.00% <ø> (ø)` | |
| [...gins/legacy-plugin-chart-rose/src/controlPanel.tsx](https://app.codecov.io/gh/apache/superset/pull/24798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXJvc2Uvc3JjL2NvbnRyb2xQYW5lbC50c3g=) | `50.00% <ø> (ø)` | |
| [...gins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx](https://app.codecov.io/gh/apache/superset/pull/24798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL05WRDNDb250cm9scy50c3g=) | `100.00% <ø> (ø)` | |
| [.../BigNumber/BigNumberWithTrendline/controlPanel.tsx](https://app.codecov.io/gh/apache/superset/pull/24798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQmlnTnVtYmVyL0JpZ051bWJlcldpdGhUcmVuZGxpbmUvY29udHJvbFBhbmVsLnRzeA==) | `16.66% <ø> (ø)` | |
| [...s/plugin-chart-echarts/src/Funnel/controlPanel.tsx](https://app.codecov.io/gh/apache/superset/pull/24798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvRnVubmVsL2NvbnRyb2xQYW5lbC50c3g=) | `66.66% <ø> (ø)` | |
| [...ns/plugin-chart-echarts/src/Gauge/controlPanel.tsx](https://app.codecov.io/gh/apache/superset/pull/24798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvR2F1Z2UvY29udHJvbFBhbmVsLnRzeA==) | `66.66% <ø> (ø)` | |
| ... and [130 more](https://app.codecov.io/gh/apache/superset/pull/24798?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24798/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org