You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/01/20 23:54:15 UTC

Review Request 55799: Cleaned up SUBSCRIBE code slightly.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55799/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos


Description
-------

Ensure `SUBSCRIBE` code is ordered consistently with respect to the
other operator call operations.


Diffs
-----

  src/master/http.cpp a44621f39cb059e654a56f57f75b38947f3a4230 
  src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0 

Diff: https://reviews.apache.org/r/55799/diff/


Testing
-------

`make check`


Thanks,

Neil Conway


Re: Review Request 55799: Cleaned up SUBSCRIBE code slightly.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55799/#review162740
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Jan. 20, 2017, 11:54 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55799/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2017, 11:54 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensure `SUBSCRIBE` code is ordered consistently with respect to the
> other operator call operations.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp a44621f39cb059e654a56f57f75b38947f3a4230 
>   src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0 
> 
> Diff: https://reviews.apache.org/r/55799/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>