[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9736: [bugfix] fix memleaks reported by ASAN

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #9736:
URL: https://github.com/apache/incubator-doris/pull/9736#discussion_r879079416


##########
be/src/vec/exprs/vexpr.h:
##########
@@ -108,7 +108,13 @@ class VExpr {
                                           VExpr* parent, int* node_idx, VExpr** root_expr,
                                           VExprContext** ctx);
     const std::vector<VExpr*>& children() const { return _children; }
-    void set_children(std::vector<VExpr*> children) { _children = children; }
+    void set_children(RuntimeState* state, VExprContext* ctx, std::vector<VExpr*> children,

Review Comment:
   this function old call in `dfs_peel_conjunct`, not need check `close_old`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org