[jira] [Updated] (HIVE-4020) Swap applying order of CP and PPD

["Phabricator (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HIVE-4020:
------------------------------

    Attachment: HIVE-4020.D8571.2.patch

navis updated the revision "HIVE-4020 [jira] Swap applying order of CP and PPD".

  Updated diff result

Reviewers: JIRA

REVISION DETAIL
  https://reviews.facebook.net/D8571

CHANGE SINCE LAST DIFF
  https://reviews.facebook.net/D8571?vs=27711&id=29127#toc

AFFECTED FILES
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java
  ql/src/test/results/clientpositive/auto_join19.q.out
  ql/src/test/results/clientpositive/auto_join9.q.out
  ql/src/test/results/clientpositive/bucketmapjoin1.q.out
  ql/src/test/results/clientpositive/bucketmapjoin_negative.q.out
  ql/src/test/results/clientpositive/filter_join_breaktask.q.out
  ql/src/test/results/clientpositive/index_auto_mult_tables.q.out
  ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out
  ql/src/test/results/clientpositive/input39_hadoop20.q.out
  ql/src/test/results/clientpositive/join38.q.out
  ql/src/test/results/clientpositive/join9.q.out
  ql/src/test/results/clientpositive/join_map_ppr.q.out
  ql/src/test/results/clientpositive/lateral_view_ppd.q.out
  ql/src/test/results/clientpositive/louter_join_ppr.q.out
  ql/src/test/results/clientpositive/ppd_repeated_alias.q.out
  ql/src/test/results/clientpositive/router_join_ppr.q.out
  ql/src/test/results/clientpositive/smb_mapjoin9.q.out
  ql/src/test/results/clientpositive/sort_merge_join_desc_1.q.out
  ql/src/test/results/clientpositive/sort_merge_join_desc_2.q.out
  ql/src/test/results/clientpositive/sort_merge_join_desc_3.q.out
  ql/src/test/results/clientpositive/sort_merge_join_desc_4.q.out
  ql/src/test/results/clientpositive/stats11.q.out
  ql/src/test/results/clientpositive/union26.q.out
  ql/src/test/results/compiler/plan/case_sensitivity.q.xml
  ql/src/test/results/compiler/plan/cast1.q.xml
  ql/src/test/results/compiler/plan/input1.q.xml
  ql/src/test/results/compiler/plan/input6.q.xml
  ql/src/test/results/compiler/plan/input9.q.xml
  ql/src/test/results/compiler/plan/input_part1.q.xml
  ql/src/test/results/compiler/plan/input_testxpath2.q.xml
  ql/src/test/results/compiler/plan/join4.q.xml
  ql/src/test/results/compiler/plan/join5.q.xml
  ql/src/test/results/compiler/plan/join6.q.xml
  ql/src/test/results/compiler/plan/join7.q.xml
  ql/src/test/results/compiler/plan/join8.q.xml
  ql/src/test/results/compiler/plan/sample7.q.xml
  ql/src/test/results/compiler/plan/subq.q.xml
  ql/src/test/results/compiler/plan/udf1.q.xml
  ql/src/test/results/compiler/plan/union.q.xml

To: JIRA, navis

                
> Swap applying order of CP and PPD
> ---------------------------------
>
>                 Key: HIVE-4020
>                 URL: https://issues.apache.org/jira/browse/HIVE-4020
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>         Attachments: HIVE-4020.D8571.1.patch, HIVE-4020.D8571.2.patch
>
>
> Doing Hive-2340, I've found CP removed some column mapping needed for backtracking expression desc. By swapping order of CP and PPD, the problem was solved. 
> After that I've realized that CP on earlier stage is possible after PPD is applied cause some columns on filter predicate are not selected and can be removed right after the new pushed-down filter. For example, (bucketmapjoin1.q)
> <noformat>
> select /*+mapjoin(b)*/ a.key, a.value, b.value
> from srcbucket_mapjoin_part a join srcbucket_mapjoin_part_2 b
> on a.key=b.key where b.ds="2008-04-08"
> <noformat>
> plan for hashtable sink operator is changed to 
> <noformat>
> HashTable Sink Operator
>   condition expressions:
>     0 {key} {value}
>     1 {value}
> <noformat>
> which was 
> <noformat>
> HashTable Sink Operator
>   condition expressions:
>     0 {key} {value}
>     1 {value} {ds}
> <noformat>
> HIVE-2340 seemed need more time for commit, so booked as an another issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira