You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by robbinspg <gi...@git.apache.org> on 2016/06/16 15:34:35 UTC
[GitHub] spark pull request #13707: [SPARK-15822][SQL] avoid UTF8String references in...
GitHub user robbinspg opened a pull request:
https://github.com/apache/spark/pull/13707
[SPARK-15822][SQL] avoid UTF8String references into freed pages
## What changes were proposed in this pull request?
In SMJ codegen we need to save copies of UTF8String values as the final iterator.next() will free the underlying memory page.
## How was this patch tested?
Test application as described in 15822 now passes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robbinspg/spark-1 master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13707.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13707
----
commit d201034e628456b9640eb8483da849217aa80c92
Author: Pete Robbins <ro...@gmail.com>
Date: 2016-06-16T14:33:31Z
Create copy of UTF8String in SMJ
commit 1288f1e88f90b751cd0640864d7cc6cb5a9dfeca
Author: Pete Robbins <ro...@gmail.com>
Date: 2016-06-16T15:21:23Z
make copy() public
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13707: [WIP][SPARK-15822][SQL] avoid UTF8String references into...
Posted by robbinspg <gi...@git.apache.org>.
Github user robbinspg commented on the issue:
https://github.com/apache/spark/pull/13707
So clearly that code doesn't work when the type is a primitive. I'm not familiar with the code generation. Is there a way to detect the type during generation rather than generating the dodgy "isinstanceof" code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13707: [WIP][SPARK-15822][SQL] avoid UTF8String references into...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13707
**[Test build #60658 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60658/consoleFull)** for PR 13707 at commit [`535cd15`](https://github.com/apache/spark/commit/535cd1591d83e4b98f4bb277b2c119349aef30b2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13707: [WIP][SPARK-15822][SQL] avoid UTF8String references into...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13707
**[Test build #60643 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60643/consoleFull)** for PR 13707 at commit [`d3ddaa9`](https://github.com/apache/spark/commit/d3ddaa9ab31be84d8a9c12ec52706c8529cf5594).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13707: [WIP][SPARK-15822][SQL] avoid UTF8String references into...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/13707
Just want to say -- nice find!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13707: [WIP][SPARK-15822][SQL] avoid UTF8String references into...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13707
**[Test build #60658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60658/consoleFull)** for PR 13707 at commit [`535cd15`](https://github.com/apache/spark/commit/535cd1591d83e4b98f4bb277b2c119349aef30b2).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13707: [SPARK-15822][SQL] avoid UTF8String references into free...
Posted by robbinspg <gi...@git.apache.org>.
Github user robbinspg commented on the issue:
https://github.com/apache/spark/pull/13707
@davies @hvanhovell Can you take a look at this. I'm not sure it is the best fix. Also are there any other types (structs, arrays etc) that are created by pointing into an UnsafeRow that could equally be affected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13707: [WIP][SPARK-15822][SQL] avoid UTF8String references into...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13707
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13707: [SPARK-15822][SQL] avoid UTF8String references into free...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13707
**[Test build #60643 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60643/consoleFull)** for PR 13707 at commit [`d3ddaa9`](https://github.com/apache/spark/commit/d3ddaa9ab31be84d8a9c12ec52706c8529cf5594).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13707: [WIP][SPARK-15822][SQL] avoid UTF8String references into...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13707
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60643/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13707: [WIP][SPARK-15822][SQL] avoid UTF8String references into...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13707
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60658/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13707: [WIP][SPARK-15822][SQL] avoid UTF8String references into...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13707
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13707: [WIP][SPARK-15822][SQL] avoid UTF8String referenc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13707
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org