You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2024/01/28 06:19:21 UTC
[PR] [SPARK-46889][CORE] Validate `spark.master.ui.decommission.allow.mode` setting [spark]
dongjoon-hyun opened a new pull request, #44916:
URL: https://github.com/apache/spark/pull/44916
### What changes were proposed in this pull request?
This PR aims to add `checkValues` to `spark.master.ui.decommission.allow.mode` configuration to validate the setting as early as possible.
### Why are the changes needed?
To prevent misconfigurations.
**BEFORE (NO WARNING)**
```
$ SPARK_NO_DAEMONIZE=1 SPARK_MASTER_OPTS="-Dspark.master.ui.decommission.allow.mode=ALLOWS" sbin/start-master.sh
...
24/01/27 22:14:25 INFO Master: I have been elected leader! New state: ALIVE
```
**AFTER (FAILURE)**
```
$ SPARK_NO_DAEMONIZE=1 SPARK_MASTER_OPTS="-Dspark.master.ui.decommission.allow.mode=ALLOWS" sbin/start-master.sh
...
java.lang.IllegalArgumentException: The value of spark.master.ui.decommission.allow.mode should be one of ALLOW, LOCAL, DENY, but was ALLOWS
```
### Does this PR introduce _any_ user-facing change?
Yes However, this prevents a user to start `Spark Master` with misconfiguration. So, it happens only at the first start of the migrated Spark master installation. So, this is going to be solved before running Spark Master successfully first time.
### How was this patch tested?
Manually.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46889][CORE] Validate `spark.master.ui.decommission.allow.mode` setting [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44916:
URL: https://github.com/apache/spark/pull/44916#issuecomment-1913768098
Thank you, @HyukjinKwon !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46889][CORE] Validate `spark.master.ui.decommission.allow.mode` setting [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44916:
URL: https://github.com/apache/spark/pull/44916#issuecomment-1913765855
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46889][CORE] Validate `spark.master.ui.decommission.allow.mode` setting [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44916: [SPARK-46889][CORE] Validate `spark.master.ui.decommission.allow.mode` setting
URL: https://github.com/apache/spark/pull/44916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org