You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Kit Chan (JIRA)" <ji...@apache.org> on 2015/12/16 12:30:47 UTC
[jira] [Commented] (TS-4083) CID 1343347: Error handling issues in
ts_lua_http.c
[ https://issues.apache.org/jira/browse/TS-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059854#comment-15059854 ]
Kit Chan commented on TS-4083:
------------------------------
will take a look. should be an easy fix.
> CID 1343347: Error handling issues in ts_lua_http.c
> ----------------------------------------------------
>
> Key: TS-4083
> URL: https://issues.apache.org/jira/browse/TS-4083
> Project: Traffic Server
> Issue Type: Bug
> Components: Lua, Plugins
> Reporter: Kit Chan
> Assignee: Kit Chan
> Fix For: 6.2.0
>
>
> {code}
> ** CID 1343347: Error handling issues (CHECKED_RETURN)
> /plugins/experimental/ts_lua/ts_lua_http.c: 337 in ts_lua_http_set_cache_url()
> ________________________________________________________________________________________________________
> *** CID 1343347: Error handling issues (CHECKED_RETURN)
> /plugins/experimental/ts_lua/ts_lua_http.c: 337 in ts_lua_http_set_cache_url()
> 331
> 332 GET_HTTP_CONTEXT(http_ctx, L);
> 333
> 334 url = luaL_checklstring(L, 1, &url_len);
> 335
> 336 if (url && url_len) {
> >>> CID 1343347: Error handling issues (CHECKED_RETURN)
> >>> Calling "TSCacheUrlSet" without checking return value (as is done elsewhere 4 out of 5 times).
> 337 TSCacheUrlSet(http_ctx->txnp, url, url_len);
> 338 }
> 339
> 340 return 0;
> 341 }
> 342
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)