You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/26 02:06:59 UTC
[GitHub] [flink] link3280 commented on a change in pull request #10674:
[FLINK-15220][Connector/Kafka][Table] Add startFromTimestamp in
KafkaTableSource
link3280 commented on a change in pull request #10674: [FLINK-15220][Connector/Kafka][Table] Add startFromTimestamp in KafkaTableSource
URL: https://github.com/apache/flink/pull/10674#discussion_r361350986
##########
File path: flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka010TableSource.java
##########
@@ -62,7 +64,8 @@ public Kafka010TableSource(
Properties properties,
DeserializationSchema<Row> deserializationSchema,
StartupMode startupMode,
- Map<KafkaTopicPartition, Long> specificStartupOffsets) {
+ Map<KafkaTopicPartition, Long> specificStartupOffsets,
+ long startupTimestampMillis) {
Review comment:
I think we'd better not mix the startup timestamp with the Kafka connector properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services