You are viewing a plain text version of this content. The canonical link for it is here.
Posted to axis-cvs@ws.apache.org by di...@apache.org on 2006/01/03 15:56:28 UTC

svn commit: r365648 - /webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/context/MessageContext.java

Author: dims
Date: Tue Jan  3 06:56:26 2006
New Revision: 365648

URL: http://svn.apache.org/viewcvs?rev=365648&view=rev
Log:
Possible Fix for build breakage. if someone calls setProperty() to a message context that gets into the properties bag in AbstractContext, but getProperty is overridden in MessageContext and should look into that bag as well.



Modified:
    webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/context/MessageContext.java

Modified: webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/context/MessageContext.java
URL: http://svn.apache.org/viewcvs/webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/context/MessageContext.java?rev=365648&r1=365647&r2=365648&view=diff
==============================================================================
--- webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/context/MessageContext.java (original)
+++ webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/context/MessageContext.java Tue Jan  3 06:56:26 2006
@@ -485,8 +485,14 @@
      * @return the value of the property, or null if the property is not found
      */
     public Object getProperty(String name) {
+        // search in my own properties bag
+        Object obj = super.getProperty(name);
+        if (obj != null) {
+            return obj;
+        }
+
         // search in my own options
-        Object obj = options.getProperty(name);
+        obj = options.getProperty(name);
         if (obj != null) {
             return obj;
         }



Re: svn commit: r365648 - /webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/context/MessageContext.java

Posted by Davanum Srinivas <da...@gmail.com>.
+1 just wanted to get the build working...

-- dims

On 1/3/06, Sanjiva Weerawarana <sa...@opensource.lk> wrote:
> On Tue, 2006-01-03 at 14:56 +0000, dims@apache.org wrote:
> > Author: dims
> > Date: Tue Jan  3 06:56:26 2006
> > New Revision: 365648
> >
> > URL: http://svn.apache.org/viewcvs?rev=365648&view=rev
> > Log:
> > Possible Fix for build breakage. if someone calls setProperty() to a
> >  message context that gets into the properties bag in AbstractContext,
> >  but getProperty is overridden in MessageContext and should look into
> >  that bag as well.
>
> Oops .. sorry; my bad. Do u mind if we override setProperty() instead of
> doing this fix? I think that's more consistent as we'd then be using
> Options for everything in message context. That's special and different
> from the rest of the contexts but there's good reason for that.
>
> Sanjiva.
>
>


--
Davanum Srinivas : http://wso2.com/blogs/

Re: svn commit: r365648 - /webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/context/MessageContext.java

Posted by Davanum Srinivas <da...@gmail.com>.
+1 just wanted to get the build working...

-- dims

On 1/3/06, Sanjiva Weerawarana <sa...@opensource.lk> wrote:
> On Tue, 2006-01-03 at 14:56 +0000, dims@apache.org wrote:
> > Author: dims
> > Date: Tue Jan  3 06:56:26 2006
> > New Revision: 365648
> >
> > URL: http://svn.apache.org/viewcvs?rev=365648&view=rev
> > Log:
> > Possible Fix for build breakage. if someone calls setProperty() to a
> >  message context that gets into the properties bag in AbstractContext,
> >  but getProperty is overridden in MessageContext and should look into
> >  that bag as well.
>
> Oops .. sorry; my bad. Do u mind if we override setProperty() instead of
> doing this fix? I think that's more consistent as we'd then be using
> Options for everything in message context. That's special and different
> from the rest of the contexts but there's good reason for that.
>
> Sanjiva.
>
>


--
Davanum Srinivas : http://wso2.com/blogs/

Re: svn commit: r365648 - /webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/context/MessageContext.java

Posted by Sanjiva Weerawarana <sa...@opensource.lk>.
On Tue, 2006-01-03 at 14:56 +0000, dims@apache.org wrote:
> Author: dims
> Date: Tue Jan  3 06:56:26 2006
> New Revision: 365648
> 
> URL: http://svn.apache.org/viewcvs?rev=365648&view=rev
> Log:
> Possible Fix for build breakage. if someone calls setProperty() to a
>  message context that gets into the properties bag in AbstractContext,
>  but getProperty is overridden in MessageContext and should look into
>  that bag as well.

Oops .. sorry; my bad. Do u mind if we override setProperty() instead of
doing this fix? I think that's more consistent as we'd then be using
Options for everything in message context. That's special and different
from the rest of the contexts but there's good reason for that.

Sanjiva.


Re: svn commit: r365648 - /webservices/axis2/trunk/java/modules/core/src/org/apache/axis2/context/MessageContext.java

Posted by Sanjiva Weerawarana <sa...@opensource.lk>.
On Tue, 2006-01-03 at 14:56 +0000, dims@apache.org wrote:
> Author: dims
> Date: Tue Jan  3 06:56:26 2006
> New Revision: 365648
> 
> URL: http://svn.apache.org/viewcvs?rev=365648&view=rev
> Log:
> Possible Fix for build breakage. if someone calls setProperty() to a
>  message context that gets into the properties bag in AbstractContext,
>  but getProperty is overridden in MessageContext and should look into
>  that bag as well.

Oops .. sorry; my bad. Do u mind if we override setProperty() instead of
doing this fix? I think that's more consistent as we'd then be using
Options for everything in message context. That's special and different
from the rest of the contexts but there's good reason for that.

Sanjiva.