You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Xu Yaning (JIRA)" <ji...@apache.org> on 2015/07/15 03:11:04 UTC
[jira] [Updated] (DIRKRB-368) Fix findbugs Problems for kerby-tool
module
[ https://issues.apache.org/jira/browse/DIRKRB-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xu Yaning updated DIRKRB-368:
-----------------------------
Description:
Findbugs maven plugin reports the following problems:
# *org.apache.kerby.kerberos.tool.kinit.KinitOption.setDescription(String)* unconditionally sets the field description;
# *org.apache.kerby.kerberos.tool.kinit.KinitOption.setName(String)* unconditionally sets the field name;
# *org.apache.kerby.kerberos.tool.kinit.KinitOption.setType(KOptionType)* unconditionally sets the field type;
# *org.apache.kerby.kerberos.tool.kinit.KinitOption.setValue(Object)* unconditionally sets the field value;
# *org.apache.kerby.kerberos.tool.klist.KlistOption.setDescription(String)* unconditionally sets the field description;
# *org.apache.kerby.kerberos.tool.klist.KlistOption.setName(String)* unconditionally sets the field name;
# *org.apache.kerby.kerberos.tool.klist.KlistOption.setType(KOptionType)* unconditionally sets the field type;
# *org.apache.kerby.kerberos.tool.klist.KlistOption.setValue(Object)* unconditionally sets the field value.
# Dead store to error in *org.apache.kerby.kerberos.tool.kinit.KinitTool.main(String[])*;
# Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kinit.KinitTool.getPassword(String)*: new java.util.Scanner(InputStream);
# *org.apache.kerby.kerberos.tool.klist.KlistTool.printCredentialCacheInfo(KOptions)* may fail to clean up java.io.InputStream;
# Found reliance on default encoding in *org.apache.kerby.kerberos.tool.token.TokenCache.readToken(String)*: new java.io.FileReader(File);
# Found reliance on default encoding in *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*: new java.io.FileWriter(File);
# *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)* may fail to clean up java.io.Writer on checked exception;
# Exceptional return value of java.io.File.delete() ignored in *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*;
# Exceptional return value of java.io.File.setWritable(boolean, boolean) ignored in *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*;
# Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kadmin.KadminTool.main(String[])*: new java.util.Scanner(InputStream);
# There is an apparent infinite loop in *org.apache.kerby.kerberos.tool.kadmin.KadminTool.main(String[])*;
# Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kadmin.ToolUtil.getReplay(String)*: new java.util.Scanner(InputStream);
# Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kadmin.command.AddPrincipalCommand.getPassword(String)*: new java.util.Scanner(InputStream);
# Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kadmin.command.ChangePasswordCommand.getPassword(String)*: new java.util.Scanner(InputStream);
# Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kadmin.command.DeletePrincipalCommand.execute(String)*: new java.util.Scanner(InputStream);
# Possible null pointer dereference of principalNames in *org.apache.kerby.kerberos.tool.kadmin.command.ListPrincipalCommand.execute(String)*;
# Dead store to error in *org.apache.kerby.kerberos.tool.kadmin.command.ModifyPrincipalCommand.parseOptions(String[])*;
# Read of unwritten field kOptions in *org.apache.kerby.kerberos.tool.kadmin.command.ModifyPrincipalCommand.parseOptions(String[])*;
# Unwritten field: *org.apache.kerby.kerberos.tool.kadmin.command.ModifyPrincipalCommand.kOptions*;
Problems 1 to 8 are required to be fixed in DIRKRB-367, the others are to be fixed here.
was:
Findbugs maven plugin reports the following problems:
# *org.apache.kerby.kerberos.tool.kinit.KinitOption.setDescription(String)* unconditionally sets the field description;
# *org.apache.kerby.kerberos.tool.kinit.KinitOption.setName(String)* unconditionally sets the field name;
# *org.apache.kerby.kerberos.tool.kinit.KinitOption.setType(KOptionType)* unconditionally sets the field type;
# *org.apache.kerby.kerberos.tool.kinit.KinitOption.setValue(Object)* unconditionally sets the field value;
# *org.apache.kerby.kerberos.tool.klist.KlistOption.setDescription(String)* unconditionally sets the field description;
# *org.apache.kerby.kerberos.tool.klist.KlistOption.setName(String)* unconditionally sets the field name;
# *org.apache.kerby.kerberos.tool.klist.KlistOption.setType(KOptionType)* unconditionally sets the field type;
# *org.apache.kerby.kerberos.tool.klist.KlistOption.setValue(Object)* unconditionally sets the field value.
# Dead store to error in *org.apache.kerby.kerberos.tool.kinit.KinitTool.main(String[])*;
# Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kinit.KinitTool.getPassword(String)*: new java.util.Scanner(InputStream);
# *org.apache.kerby.kerberos.tool.klist.KlistTool.printCredentialCacheInfo(KOptions)* may fail to clean up java.io.InputStream;
# Found reliance on default encoding in *org.apache.kerby.kerberos.tool.token.TokenCache.readToken(String)*: new java.io.FileReader(File);
# Found reliance on default encoding in *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*: new java.io.FileWriter(File);
# *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)* may fail to clean up java.io.Writer on checked exception;
# Exceptional return value of java.io.File.delete() ignored in *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*;
# Exceptional return value of java.io.File.setWritable(boolean, boolean) ignored in *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*;
Problems 1 to 8 are required to be fixed in DIRKRB-367, the others are to be fixed here.
> Fix findbugs Problems for kerby-tool module
> -------------------------------------------
>
> Key: DIRKRB-368
> URL: https://issues.apache.org/jira/browse/DIRKRB-368
> Project: Directory Kerberos
> Issue Type: Sub-task
> Reporter: Xu Yaning
> Assignee: Xu Yaning
>
> Findbugs maven plugin reports the following problems:
> # *org.apache.kerby.kerberos.tool.kinit.KinitOption.setDescription(String)* unconditionally sets the field description;
> # *org.apache.kerby.kerberos.tool.kinit.KinitOption.setName(String)* unconditionally sets the field name;
> # *org.apache.kerby.kerberos.tool.kinit.KinitOption.setType(KOptionType)* unconditionally sets the field type;
> # *org.apache.kerby.kerberos.tool.kinit.KinitOption.setValue(Object)* unconditionally sets the field value;
> # *org.apache.kerby.kerberos.tool.klist.KlistOption.setDescription(String)* unconditionally sets the field description;
> # *org.apache.kerby.kerberos.tool.klist.KlistOption.setName(String)* unconditionally sets the field name;
> # *org.apache.kerby.kerberos.tool.klist.KlistOption.setType(KOptionType)* unconditionally sets the field type;
> # *org.apache.kerby.kerberos.tool.klist.KlistOption.setValue(Object)* unconditionally sets the field value.
> # Dead store to error in *org.apache.kerby.kerberos.tool.kinit.KinitTool.main(String[])*;
> # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kinit.KinitTool.getPassword(String)*: new java.util.Scanner(InputStream);
> # *org.apache.kerby.kerberos.tool.klist.KlistTool.printCredentialCacheInfo(KOptions)* may fail to clean up java.io.InputStream;
> # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.token.TokenCache.readToken(String)*: new java.io.FileReader(File);
> # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*: new java.io.FileWriter(File);
> # *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)* may fail to clean up java.io.Writer on checked exception;
> # Exceptional return value of java.io.File.delete() ignored in *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*;
> # Exceptional return value of java.io.File.setWritable(boolean, boolean) ignored in *org.apache.kerby.kerberos.tool.token.TokenCache.writeToken(String)*;
> # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kadmin.KadminTool.main(String[])*: new java.util.Scanner(InputStream);
> # There is an apparent infinite loop in *org.apache.kerby.kerberos.tool.kadmin.KadminTool.main(String[])*;
> # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kadmin.ToolUtil.getReplay(String)*: new java.util.Scanner(InputStream);
> # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kadmin.command.AddPrincipalCommand.getPassword(String)*: new java.util.Scanner(InputStream);
> # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kadmin.command.ChangePasswordCommand.getPassword(String)*: new java.util.Scanner(InputStream);
> # Found reliance on default encoding in *org.apache.kerby.kerberos.tool.kadmin.command.DeletePrincipalCommand.execute(String)*: new java.util.Scanner(InputStream);
> # Possible null pointer dereference of principalNames in *org.apache.kerby.kerberos.tool.kadmin.command.ListPrincipalCommand.execute(String)*;
> # Dead store to error in *org.apache.kerby.kerberos.tool.kadmin.command.ModifyPrincipalCommand.parseOptions(String[])*;
> # Read of unwritten field kOptions in *org.apache.kerby.kerberos.tool.kadmin.command.ModifyPrincipalCommand.parseOptions(String[])*;
> # Unwritten field: *org.apache.kerby.kerberos.tool.kadmin.command.ModifyPrincipalCommand.kOptions*;
> Problems 1 to 8 are required to be fixed in DIRKRB-367, the others are to be fixed here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)