[GitHub] [nifi] exceptionfactory commented on a change in pull request #5884: NIFI-9786 Add debug logs if keystore cannot be loaded

[GitBox <gi...@apache.org>]

exceptionfactory commented on a change in pull request #5884:
URL: https://github.com/apache/nifi/pull/5884#discussion_r831096975



##########
File path: nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/util/KeyStoreUtils.java
##########
@@ -401,6 +401,7 @@ public static boolean isStoreValid(final URL keystore, final KeystoreType keysto
             return true;
 
         } catch (Exception e) {
+            logger.debug("Keystore could not be loaded", e);

Review comment:
       Recommend including the keystore location and keystore type for additional debugging:
   ```suggestion
               logger.debug("Keystore [{}] Type [{}] load failed", keystore, keystoreType, e);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org