You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/12/05 03:25:25 UTC

[GitHub] [bookkeeper] horizonzy commented on a diff in pull request #3654: Fix numLedgersReplicated metric

horizonzy commented on code in PR #3654:
URL: https://github.com/apache/bookkeeper/pull/3654#discussion_r1039111608


##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/TestReplicationWorker.java:
##########
@@ -1262,6 +1267,9 @@ protected EnsemblePlacementPolicy initializeEnsemblePlacementPolicy(ClientConfig
             assertNull(stat1);
         });
 
+        assertEquals("NUM_FULL_OR_PARTIAL_LEDGERS_REPLICATED",

Review Comment:
   This is good enough. If we added a test to cover `numLedgersReplicatedCounter` didn't increase the case, that would be better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org