You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/05 11:57:01 UTC

[GitHub] [flink] smattheis opened a new pull request #18984: [hotfix][docs] Fix HTML formatting in ops/metrics.md

smattheis opened a new pull request #18984:
URL: https://github.com/apache/flink/pull/18984


   ## What is the purpose of the change
   
   Fix HTML in ops/metrics.md
   
   ## Brief change log
   
   Fix 'Note' paragraph and adapt to style to other 'Note' paragraphs of the rest of the document.
   
   ## Verifying this change
   
   Not applicable.
   
   ## Does this pull request potentially affect one of the following parts:
   
   Only docs affected
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18984: [hotfix][docs] Fix HTML formatting in ops/metrics.md

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18984:
URL: https://github.com/apache/flink/pull/18984#issuecomment-1059750454


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "725082e709bb8ed23e90eeac3e1aa6ddee7f5f69",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32564",
       "triggerID" : "725082e709bb8ed23e90eeac3e1aa6ddee7f5f69",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 725082e709bb8ed23e90eeac3e1aa6ddee7f5f69 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32564) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] smattheis commented on pull request #18984: [hotfix][docs] Fix HTML formatting in ops/metrics.md

Posted by GitBox <gi...@apache.org>.
smattheis commented on pull request #18984:
URL: https://github.com/apache/flink/pull/18984#issuecomment-1060810788


   > By locally I meant building the docs locally (described in the readme I think: https://github.com/apache/flink/tree/master/docs ), just to be sure it's working fine.
   
   No, I wasn't aware of that. Will check it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] smattheis commented on pull request #18984: [hotfix][docs] Fix HTML formatting in ops/metrics.md

Posted by GitBox <gi...@apache.org>.
smattheis commented on pull request #18984:
URL: https://github.com/apache/flink/pull/18984#issuecomment-1060652014


   > Thanks for the fix @smattheis . Have you checked locally that this is now working fine?
   > 
   > Can you explain what was the problem before? Empty line was prematurely terminating the table?
   
   Yes, exactly the new line was breaking the HTML rendering. I have checked locally via IntelliJ markdown rendering that it should be fixed now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18984: [hotfix][docs] Fix HTML formatting in ops/metrics.md

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18984:
URL: https://github.com/apache/flink/pull/18984#issuecomment-1059750454


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "725082e709bb8ed23e90eeac3e1aa6ddee7f5f69",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "725082e709bb8ed23e90eeac3e1aa6ddee7f5f69",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 725082e709bb8ed23e90eeac3e1aa6ddee7f5f69 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18984: [hotfix][docs] Fix HTML formatting in ops/metrics.md

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18984:
URL: https://github.com/apache/flink/pull/18984#issuecomment-1059750454


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "725082e709bb8ed23e90eeac3e1aa6ddee7f5f69",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32564",
       "triggerID" : "725082e709bb8ed23e90eeac3e1aa6ddee7f5f69",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 725082e709bb8ed23e90eeac3e1aa6ddee7f5f69 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32564) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pnowojski commented on pull request #18984: [hotfix][docs] Fix HTML formatting in ops/metrics.md

Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #18984:
URL: https://github.com/apache/flink/pull/18984#issuecomment-1060778366


   By locally I meant building the docs locally (described in the readme I think: https://github.com/apache/flink/tree/master/docs ), just to be sure it's working fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] smattheis commented on pull request #18984: [hotfix][docs] Fix HTML formatting in ops/metrics.md

Posted by GitBox <gi...@apache.org>.
smattheis commented on pull request #18984:
URL: https://github.com/apache/flink/pull/18984#issuecomment-1060816754


   > By locally I meant building the docs locally (described in the readme I think: https://github.com/apache/flink/tree/master/docs ), just to be sure it's working fine.
   
   @pnowojski Checked it. It's fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pnowojski merged pull request #18984: [hotfix][docs] Fix HTML formatting in ops/metrics.md

Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #18984:
URL: https://github.com/apache/flink/pull/18984


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] smattheis commented on pull request #18984: [hotfix][docs] Fix HTML formatting in ops/metrics.md

Posted by GitBox <gi...@apache.org>.
smattheis commented on pull request #18984:
URL: https://github.com/apache/flink/pull/18984#issuecomment-1061513936


   @pnowojski backport to any previous version not required as `watermarkAlignmentDrift` is new in 1.15


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org