You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/11 00:27:12 UTC

[GitHub] [airflow] ferruzzi opened a new pull request #21508: Update EKS sample DAGs and docs

ferruzzi opened a new pull request #21508:
URL: https://github.com/apache/airflow/pull/21508


   Part of a project to standardize AWS provider package sample DAGs and documentation.
   
   - Adds entries in the docs for the three EKS State Sensors
   - All EKS sample DAGs are reformatted to be more consistent and to make the embedded snippets in the docs more approachable
   - There is an example DAG that shows off how to use Jinja templates but it didn't actually use them for much, so I made that a better demo.
   
   related: https://github.com/apache/airflow/pull/21475 
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ferruzzi edited a comment on pull request #21508: Update EKS sample DAGs and docs

Posted by GitBox <gi...@apache.org>.
ferruzzi edited a comment on pull request #21508:
URL: https://github.com/apache/airflow/pull/21508#issuecomment-1035685355


   Fixing two of the three errors (my oops) but not sure about this one.
   
   ```
   File "/opt/airflow/airflow/providers/amazon/aws/example_dags/example_eks_templated.py", line 58, in <module>
   VPC_CONFIG = json.loads("{{ dag_run.conf['resources_vpc_config'] }}")
       <<snip>>
   json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 1 column 2 (char 1)
    ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ferruzzi commented on pull request #21508: Update EKS sample DAGs and docs

Posted by GitBox <gi...@apache.org>.
ferruzzi commented on pull request #21508:
URL: https://github.com/apache/airflow/pull/21508#issuecomment-1036417062


   oof.  Sorry about that, I must have screwed up a rebase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ferruzzi closed pull request #21508: Update EKS sample DAGs and docs

Posted by GitBox <gi...@apache.org>.
ferruzzi closed pull request #21508:
URL: https://github.com/apache/airflow/pull/21508


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ferruzzi commented on pull request #21508: Update EKS sample DAGs and docs

Posted by GitBox <gi...@apache.org>.
ferruzzi commented on pull request #21508:
URL: https://github.com/apache/airflow/pull/21508#issuecomment-1035685355


   Fixing two of the three errors (my oops) but not sure about this one.
   
   ```
        File "/opt/airflow/airflow/providers/amazon/aws/example_dags/example_eks_templated.py", line 58, in <module>
         VPC_CONFIG = json.loads("{{ dag_run.conf['resources_vpc_config'] }}")
       <<snip>>
     json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 1 column 2 (char 1)
     ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org