You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/06/03 16:06:49 UTC
[GitHub] [trafficserver] SolidWallOfCode opened a new pull request, #8885: Update to libswoc 1.3.8
SolidWallOfCode opened a new pull request, #8885:
URL: https://github.com/apache/trafficserver/pull/8885
Update libswoc to [1.3.8](https://github.com/SolidWallOfCode/libswoc/releases/tag/1.3.8). This has a number of minor improvements and introduces the `Vectray` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8885: Update to libswoc 1.3.8
Posted by GitBox <gi...@apache.org>.
bneradt commented on PR #8885:
URL: https://github.com/apache/trafficserver/pull/8885#issuecomment-1146175463
OK, I reproduced this locally. This is kind of funny. We check the report like so:
https://github.com/apache/trafficserver-ci/blob/main/jenkins/github/rat.pipeline#L57
On master, that grep produces this:
```
$ grep '0 Unknown Licenses' RAT.txt
30 Unknown Licenses
```
See, it passes. The report has literally the string `0 Unknown Licenses`. Unfortunately there's a 3 in front of that.
With your patch in this PR, @SolidWallOfCode , this report now shows 31 Unknown Licenses:
```
31 Unknown Licenses
```
Therefore the grep fails.
Clearly we need to update CI to check more precisely. In the meantime, I'm not sure what to do about these licenses. Do we have to officially vet this with someone in Apache?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #8885: Update to libswoc 1.3.8
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on PR #8885:
URL: https://github.com/apache/trafficserver/pull/8885#issuecomment-1146149617
I'm unclear on why RAT is failing now, and not when this was originally added. My approach is to exclude "swoc" from RAT as is done for YAML-CPP. We might want to check with the ASF if the libswoc style is acceptable, which AFAIK is the case.
It's the same version of libswoc you reviewed earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8885: Update to libswoc 1.3.8
Posted by GitBox <gi...@apache.org>.
bneradt commented on PR #8885:
URL: https://github.com/apache/trafficserver/pull/8885#issuecomment-1146275357
> However we may want to update our RAT checking.
I don't think updating is a simple thing for us. We simply use Apache's https://github.com/apache/creadur-rat. I was hoping the latest version would support the short license format, but I do not see any updates to that which would accept shortened SPDX URLs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode merged pull request #8885: Update to libswoc 1.3.8
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode merged PR #8885:
URL: https://github.com/apache/trafficserver/pull/8885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a diff in pull request #8885: Update to libswoc 1.3.8
Posted by GitBox <gi...@apache.org>.
bneradt commented on code in PR #8885:
URL: https://github.com/apache/trafficserver/pull/8885#discussion_r889261033
##########
ci/rat-regex.txt:
##########
@@ -67,4 +67,5 @@ port\.h
^catch[.]hpp$
^configuru.hpp$
^yamlcpp$
+^swoc$
Review Comment:
Since that's what we do with yamlcpp files, I suppose this fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #8885: Update to libswoc 1.3.8
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on PR #8885:
URL: https://github.com/apache/trafficserver/pull/8885#issuecomment-1146208446
We're treating libswoc as a third party library and so we can exclude it from the checks as we do with YAML-CPP. However we may want to update our RAT checking. If you look [here](https://www.apache.org/licenses/LICENSE-2.0) you can see the ASF supports the SPDX notation used in libswoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org