You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/23 19:14:35 UTC

[GitHub] [incubator-superset] ktmud opened a new pull request #9639: docs: remove references to superset-ui-plugins

ktmud opened a new pull request #9639:
URL: https://github.com/apache/incubator-superset/pull/9639


   #9030 # CATEGORY
   
   - [x] Documentation
   
   ### SUMMARY
   
   `superset-ui-plugins` [has been deprecated](https://github.com/apache-superset/superset-ui/pull/332) We now manages
   all basic visualizations in [apache-superset/superset-ui](https://github.com/apache-superset/superset-ui) . Updating CONTRIBUTING.md to reflect the change.
   
   Fortunately `npm link *` still work for all `superset-ui` packages.
   
   ```
   npm link ~/projects/superset-ui/{packages,plugins}/*
   ```
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A
   
   ### TEST PLAN
   
   N/A
   
   ### ADDITIONAL INFORMATION
   
   N/A
   
   ### REVIEWERS
   
   @evans @suddjian @kristw 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9639: docs: remove references to superset-ui-plugins

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9639:
URL: https://github.com/apache/incubator-superset/pull/9639#discussion_r414057151



##########
File path: CONTRIBUTING.md
##########
@@ -88,9 +88,7 @@ little bit helps, and credit will always be given.
     - [Y Axis 2](#y-axis-2)
     - [Query](#query)
     - [Filters Configuration](#filters-configuration)
-    - [Options](#options)
     - [Chart Options](#chart-options)
-    - [X Axis](#x-axis)

Review comment:
       These TOC entries are updated automatically by my markdown linter.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org