[GitHub] dewrich commented on a change in pull request #2300: Add TO Go cachegroups/id/deliveryservices

[GitBox <gi...@apache.org>]

dewrich commented on a change in pull request #2300: Add TO Go cachegroups/id/deliveryservices
URL: https://github.com/apache/trafficcontrol/pull/2300#discussion_r217508429
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/cachegroup/dspost.go
 ##########
 @@ -0,0 +1,290 @@
+package cachegroup
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import (
+	"database/sql"
+	"encoding/json"
+	"errors"
+	"fmt"
+	"net/http"
+	"strconv"
+
+	"github.com/apache/trafficcontrol/lib/go-tc"
+	"github.com/apache/trafficcontrol/lib/go-util"
+	"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api"
+	"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/auth"
+	"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/tenant"
+
+	"github.com/lib/pq"
+)
+
+func DSPostHandler(w http.ResponseWriter, r *http.Request) {
+	inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"id"}, []string{"id"})
+	if userErr != nil || sysErr != nil {
+		api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr)
+		return
+	}
+	defer inf.Close()
+
+	req := tc.CachegroupPostDSReq{}
+	if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
+		api.HandleErr(w, r, inf.Tx.Tx, http.StatusBadRequest, errors.New("malformed JSON: "+err.Error()), nil)
+		return
+	}
+	vals := map[string]interface{}{
+		"alerts": tc.CreateAlerts(tc.SuccessLevel, "Delivery services successfully assigned to all the servers of cache group "+strconv.Itoa(inf.IntParams["id"])+".").Alerts,
+	}
+	api.RespWriterVals(w, r, inf.Tx.Tx, vals)(postDSes(inf.Tx.Tx, inf.User, int64(inf.IntParams["id"]), req.DeliveryServices))
+}
+
+func postDSes(tx *sql.Tx, user *auth.CurrentUser, cgID int64, dsIDs []int64) (tc.CacheGroupPostDSResp, error) {
+	cdnName, err := getCachegroupCDN(tx, cgID)
+	if err != nil {
+		return tc.CacheGroupPostDSResp{}, errors.New("getting cachegroup CDN: " + err.Error())
+	}
+
+	tenantIDs, err := getDSTenants(tx, dsIDs)
+	if err != nil {
+		return tc.CacheGroupPostDSResp{}, errors.New("getting delivery service tennat IDs: " + err.Error())
+	}
+	for _, tenantID := range tenantIDs {
+		ok, err := tenant.IsResourceAuthorizedToUserTx(int(tenantID), user, tx)
+		if err != nil {
+			return tc.CacheGroupPostDSResp{}, errors.New("checking tenancy: " + err.Error())
+		}
+		if !ok {
+			return tc.CacheGroupPostDSResp{}, errors.New("not authorized for delivery service tenant " + strconv.FormatInt(tenantID, 10))
+		}
+	}
+
+	if err := verifyDSesCDN(tx, dsIDs, cdnName); err != nil {
+		return tc.CacheGroupPostDSResp{}, errors.New("verifying delivery service CDNs match cachegroup server CDNs: " + err.Error())
+	}
+	cgServers, err := getCachegroupServers(tx, cgID)
+	if err != nil {
+		return tc.CacheGroupPostDSResp{}, errors.New("getting cachegroup server names " + err.Error())
+	}
+	if err := insertCachegroupDSes(tx, cgID, dsIDs); err != nil {
+		return tc.CacheGroupPostDSResp{}, errors.New("inserting cachegroup delivery services: " + err.Error())
+	}
+
+	if err := updateParams(tx, dsIDs); err != nil {
+		return tc.CacheGroupPostDSResp{}, errors.New("updating delivery service parameters: " + err.Error())
+	}
+	api.CreateChangeLogRawTx(api.ApiChange, fmt.Sprintf("assign servers in cache group %v to deliveryservices %v", cgID, dsIDs), user, tx)
+	return tc.CacheGroupPostDSResp{ID: util.JSONIntStr(cgID), ServerNames: cgServers, DeliveryServices: dsIDs}, nil
+}
+
+func insertCachegroupDSes(tx *sql.Tx, cgID int64, dsIDs []int64) error {
+	_, err := tx.Exec(`
+INSERT INTO deliveryservice_server (deliveryservice, server) (
+  SELECT unnest($1::int[]), server.id
+  FROM server
+  JOIN type on type.id = server.type
+  WHERE server.cachegroup = $2
+  AND (type.name LIKE 'EDGE%' OR type.name LIKE 'ORG%')
+) ON CONFLICT DO NOTHING
+`, pq.Array(dsIDs), cgID)
+	if err != nil {
+		return errors.New("inserting cachegroup servers: " + err.Error())
+	}
+	return nil
+}
+
+func getCachegroupServers(tx *sql.Tx, cgID int64) ([]tc.CacheName, error) {
+	q := `
+SELECT server.host_name FROM server
+JOIN type on type.id = server.type
+WHERE server.cachegroup = $1
+AND (type.name LIKE 'EDGE%' OR type.name LIKE 'ORG%')
+`
+	rows, err := tx.Query(q, cgID)
+	if err != nil {
+		return nil, errors.New("selecting cachegroup servers: " + err.Error())
+	}
+	defer rows.Close()
+	names := []tc.CacheName{}
+	for rows.Next() {
+		name := ""
+		if err := rows.Scan(&name); err != nil {
+			return nil, errors.New("querying cachegroup server names: " + err.Error())
+		}
+		names = append(names, tc.CacheName(name))
+	}
+	return names, nil
+}
+
+func verifyDSesCDN(tx *sql.Tx, dsIDs []int64, cdn string) error {
+	q := `
+SELECT count(cdn.name)
+FROM cdn
+JOIN deliveryservice as ds on ds.cdn_id = cdn.id
+WHERE ds.id = ANY($1::bigint[])
+AND cdn.name <> $2::text
+`
+	count := 0
+	if err := tx.QueryRow(q, pq.Array(dsIDs), cdn).Scan(&count); err != nil {
+		return errors.New("querying cachegroup CDNs: " + err.Error())
+	}
+	if count > 0 {
+		return errors.New("servers/deliveryservices do not belong to same cdn '" + cdn + "'")
+	}
+	return nil
+}
+
+func getCachegroupCDN(tx *sql.Tx, cgID int64) (string, error) {
+	q := `
+SELECT cdn.name
+FROM cdn
+JOIN server on server.cdn_id = cdn.id
+JOIN type on server.type = type.id
+WHERE server.cachegroup = $1
+AND (type.name LIKE 'EDGE%' OR type.name LIKE 'ORG%')
+`
+	rows, err := tx.Query(q, cgID)
+	if err != nil {
+		return "", errors.New("selecting cachegroup CDNs: " + err.Error())
+	}
+	defer rows.Close()
+	cdn := ""
+	for rows.Next() {
+		serverCDN := ""
+		if err := rows.Scan(&serverCDN); err != nil {
+			return "", errors.New("scanning cachegroup CDN: " + err.Error())
+		}
+		if cdn == "" {
+			cdn = serverCDN
+		}
+		if cdn != serverCDN {
+			return "", errors.New("cachegroup servers have different CDNs '" + cdn + "' and '" + serverCDN + "'")
+		}
+	}
+	if cdn == "" {
+		return "", errors.New("no edge or origin servers found on cachegroup " + strconv.FormatInt(cgID, 10))
+	}
+	return cdn, nil
+}
+
+// updateParams updated the header rewrite, cacheurl, and regex remap params for the given edge caches, on the given delivery services. NOTE it does not update Mid params.
+func updateParams(tx *sql.Tx, dsIDs []int64) error {
+	if err := updateDSParam(tx, dsIDs, "hdr_rw_", "edge_header_rewrite"); err != nil {
+		return err
+	}
+	if err := updateDSParam(tx, dsIDs, "cacheurl_", "cacheurl"); err != nil {
+		return err
+	}
+	if err := updateDSParam(tx, dsIDs, "regex_remap_", "regex_remap"); err != nil {
+		return err
+	}
+	return nil
+}
+
+func updateDSParam(tx *sql.Tx, dsIDs []int64, paramPrefix string, dsField string) error {
+	_, err := tx.Exec(`
+DELETE FROM parameter
+WHERE name = 'location'
+AND config_file IN (
+  SELECT CONCAT('`+paramPrefix+`', xml_id, '.config')
+  FROM deliveryservice as ds
+  WHERE ds.id = ANY($1)
+  AND (ds.`+dsField+` IS NULL OR ds.`+dsField+` = '')
+)
+`, pq.Array(dsIDs))
+	if err != nil {
+		return err
+	}
+
+	rows, err := tx.Query(`
+WITH ats_config_location AS (
+  SELECT TRIM(TRAILING '/' FROM value) as v FROM parameter WHERE name = 'location' AND config_file = 'remap.config'
+)
+INSERT INTO parameter (name, config_file, value) (
+  SELECT
+    'location' as name,
+    CONCAT('`+paramPrefix+`', xml_id, '.config'),
+    (select v from ats_config_location)
+  FROM deliveryservice WHERE id = ANY($1)
+) ON CONFLICT (name, config_file, value) DO UPDATE SET id = EXCLUDED.id RETURNING id
+`, pq.Array(dsIDs))
+	if err != nil {
+		return errors.New("inserting parameters: " + err.Error())
+	}
+	ids := []int64{}
+	for rows.Next() {
+		id := int64(0)
+		if err := rows.Scan(&id); err != nil {
+			return errors.New("scanning inserted parameters: " + err.Error())
+		}
+		ids = append(ids, id)
+	}
+
+	_, err = tx.Exec(`
+INSERT INTO profile_parameter (parameter, profile) (
+  SELECT UNNEST($1::int[]), server.profile
+  FROM server
+  JOIN deliveryservice_server as dss ON dss.server = server.id
+  JOIN deliveryservice as ds ON ds.id = dss.deliveryservice
+  WHERE ds.id = ANY($2)
+) ON CONFLICT DO NOTHING
+`, pq.Array(ids), pq.Array(dsIDs))
+	if err != nil {
+		return errors.New("inserting profile parameters: " + err.Error())
+	}
+	return nil
+}
+
+func deleteConfigFile(tx *sql.Tx, configFile string) error {
+	_, err := tx.Exec(`DELETE FROM parameter WHERE name = 'location' AND config_file = $1`, configFile)
+	return err
+}
+
+func getDSTenants(tx *sql.Tx, dsIDs []int64) ([]int64, error) {
+	q := `
+SELECT COALESCE(tenant_id, 0) FROM deliveryservice
+WHERE deliveryservice.id = ANY($1)
+`
+	rows, err := tx.Query(q, pq.Array(dsIDs))
+	if err != nil {
+		return nil, errors.New("selecting delivery service tenants: " + err.Error())
+	}
+	defer rows.Close()
+	tenantIDs := []int64{}
+	for rows.Next() {
+		id := int64(0)
+		if err := rows.Scan(&id); err != nil {
+			return nil, errors.New("querying cachegroup delivery service tenants: " + err.Error())
+		}
+		tenantIDs = append(tenantIDs, id)
+	}
+	return tenantIDs, nil
+}
+
+// FinishTx commits the transaction if commit is true when it's called, otherwise it rolls back the transaction. This is designed to be called in a defer.
+func FinishTx(tx *sql.Tx, commit *bool) {
 
 Review comment:
   Is this something that needs to be implemented on all Handlers now?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services