Re: Review Request 24116: Defining stubs for the Update APIs.

[Maxim Khutornenko <ma...@apache.org>]

> On July 31, 2014, 6:54 p.m., Mark Chu-Carroll wrote:
> >

Thanks Mark. All your concerns are already addressed in the latest diff.


> On July 31, 2014, 6:54 p.m., Mark Chu-Carroll wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 508
> > <https://reviews.apache.org/r/24116/diff/1/?file=646275#file646275line508>
> >
> >     Total nit, but shouldn't min come before max?


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24116/#review49271
-----------------------------------------------------------


On July 31, 2014, 6:37 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24116/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 6:37 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-611
>     https://issues.apache.org/jira/browse/AURORA-611
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> First stab at update APIs.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 12de5a3e9e3aae217b30c385e2d7ec7b43863ae2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 54b8985971719247a5d42d8676075a51045bbb92 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 2ea4a9ba0a1ea81fea5c4f5203457aa79ae67c10 
> 
> Diff: https://reviews.apache.org/r/24116/diff/
> 
> 
> Testing
> -------
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>