You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/23 15:50:44 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #25251: Make codespace run successfully

potiuk commented on code in PR #25251:
URL: https://github.com/apache/airflow/pull/25251#discussion_r928137342


##########
scripts/ci/docker-compose/local.yml:
##########
@@ -27,12 +27,6 @@ services:
     # tests (such as logs)
     volumes:
       # START automatically generated volumes from VOLUMES_FOR_SELECTED_MOUNTS in docker_command_utils.py
-      - type: bind

Review Comment:
   Those can't be removed. You need to make them work for `breeze` experience. Docker-compose here is NOT EXCLUSIVELY for codespaces. It is there to Power "Breeze" environment, which is the main environment not only for some contributors but also for our CI, So removing those is not good (especially that those entries (as you can see aboeve) are automatically generated based on definition of which volumes shold be mounted (see the comment just above). 
   
   We need to find another way if this faile on devcontainer (but it is strange because it worked before).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org