You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars George (JIRA)" <ji...@apache.org> on 2011/06/02 21:53:47 UTC
[jira] [Created] (HBASE-3949) Add "Master" link to RegionServer
pages
Add "Master" link to RegionServer pages
---------------------------------------
Key: HBASE-3949
URL: https://issues.apache.org/jira/browse/HBASE-3949
Project: HBase
Issue Type: Improvement
Components: regionserver
Affects Versions: 0.90.3, 0.92.0
Reporter: Lars George
Priority: Minor
Fix For: 0.90.4, 0.92.0
Use the ZK info where the master is to add a UI link on the top of each RegionServer page. Currently you cannot navigate directly to the Master UI once you are on a RS page.
Not sure if the info port is exposed OTTOMH, but we could either use the RS local config setting for that or add it to ZK to enable lookup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3949) Add "Master" link to RegionServer
pages
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182379#comment-13182379 ]
jiraposter@reviews.apache.org commented on HBASE-3949:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3398/#review4261
-----------------------------------------------------------
Ship it!
looks good to me.
- Todd
On 2012-01-05 01:28:49, Gregory Chanan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3398/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-05 01:28:49)
bq.
bq.
bq. Review request for hbase, Todd Lipcon and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch addresses HBASE-3949: Add "Master" link to RegionServer pages
bq.
bq. I used the first suggestion in the patch, "use the RS local config setting"
bq.
bq.
bq. This addresses bug HBASE-3949.
bq. https://issues.apache.org/jira/browse/HBASE-3949
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon 24caabd
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 6ac23d6
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 64e61bb
bq.
bq. Diff: https://reviews.apache.org/r/3398/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. - Ran unit test TestRSStatusServlet.java {Passed}
bq.
bq. - Ran a few simple configurations:
bq. - No hbase.master.info.port specified (default) {Link worked}
bq. - hbase.master.info.port specified and > 0 {Link worked}
bq. - hbase.master.info.port specified and < 0 {Printed proper message}
bq.
bq.
bq. Thanks,
bq.
bq. Gregory
bq.
bq.
> Add "Master" link to RegionServer pages
> ---------------------------------------
>
> Key: HBASE-3949
> URL: https://issues.apache.org/jira/browse/HBASE-3949
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.90.3, 0.92.0
> Reporter: Lars George
> Assignee: Gregory Chanan
> Priority: Minor
> Labels: noob
>
> Use the ZK info where the master is to add a UI link on the top of each RegionServer page. Currently you cannot navigate directly to the Master UI once you are on a RS page.
> Not sure if the info port is exposed OTTOMH, but we could either use the RS local config setting for that or add it to ZK to enable lookup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-3949) Add "Master" link to RegionServer
pages
Posted by "Todd Lipcon (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon resolved HBASE-3949.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.94.0
Committed to trunk. The patch didn't apply to the 92 branch as is - if we want this in 92, we'll have to prepare a separate patch.
> Add "Master" link to RegionServer pages
> ---------------------------------------
>
> Key: HBASE-3949
> URL: https://issues.apache.org/jira/browse/HBASE-3949
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.90.3, 0.92.0
> Reporter: Lars George
> Assignee: Gregory Chanan
> Priority: Minor
> Labels: noob
> Fix For: 0.94.0
>
>
> Use the ZK info where the master is to add a UI link on the top of each RegionServer page. Currently you cannot navigate directly to the Master UI once you are on a RS page.
> Not sure if the info port is exposed OTTOMH, but we could either use the RS local config setting for that or add it to ZK to enable lookup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3949) Add "Master" link to RegionServer
pages
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180083#comment-13180083 ]
jiraposter@reviews.apache.org commented on HBASE-3949:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3398/
-----------------------------------------------------------
(Updated 2012-01-05 01:28:49.385063)
Review request for hbase, Todd Lipcon and Michael Stack.
Changes
-------
Have servlet read Configuration rather than passing it as a context attribute
Summary
-------
This patch addresses HBASE-3949: Add "Master" link to RegionServer pages
I used the first suggestion in the patch, "use the RS local config setting"
This addresses bug HBASE-3949.
https://issues.apache.org/jira/browse/HBASE-3949
Diffs (updated)
-----
src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon 24caabd
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 6ac23d6
src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 64e61bb
Diff: https://reviews.apache.org/r/3398/diff
Testing
-------
- Ran unit test TestRSStatusServlet.java {Passed}
- Ran a few simple configurations:
- No hbase.master.info.port specified (default) {Link worked}
- hbase.master.info.port specified and > 0 {Link worked}
- hbase.master.info.port specified and < 0 {Printed proper message}
Thanks,
Gregory
> Add "Master" link to RegionServer pages
> ---------------------------------------
>
> Key: HBASE-3949
> URL: https://issues.apache.org/jira/browse/HBASE-3949
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.90.3, 0.92.0
> Reporter: Lars George
> Assignee: Gregory Chanan
> Priority: Minor
> Labels: noob
>
> Use the ZK info where the master is to add a UI link on the top of each RegionServer page. Currently you cannot navigate directly to the Master UI once you are on a RS page.
> Not sure if the info port is exposed OTTOMH, but we could either use the RS local config setting for that or add it to ZK to enable lookup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3949) Add "Master" link to RegionServer
pages
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183130#comment-13183130 ]
Hudson commented on HBASE-3949:
-------------------------------
Integrated in HBase-TRUNK-security #70 (See [https://builds.apache.org/job/HBase-TRUNK-security/70/])
HBASE-3949. Add "Master" link to RegionServer pages. Contributed by Gregory Chanan.
todd :
Files :
* /hbase/trunk/src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java
> Add "Master" link to RegionServer pages
> ---------------------------------------
>
> Key: HBASE-3949
> URL: https://issues.apache.org/jira/browse/HBASE-3949
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.90.3, 0.92.0
> Reporter: Lars George
> Assignee: Gregory Chanan
> Priority: Minor
> Labels: noob
> Fix For: 0.94.0
>
>
> Use the ZK info where the master is to add a UI link on the top of each RegionServer page. Currently you cannot navigate directly to the Master UI once you are on a RS page.
> Not sure if the info port is exposed OTTOMH, but we could either use the RS local config setting for that or add it to ZK to enable lookup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3949) Add "Master" link to RegionServer
pages
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180051#comment-13180051 ]
jiraposter@reviews.apache.org commented on HBASE-3949:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3398/
-----------------------------------------------------------
Review request for hbase, Todd Lipcon and Michael Stack.
Summary
-------
This patch addresses HBASE-3949: Add "Master" link to RegionServer pages
I used the first suggestion in the patch, "use the RS local config setting"
This addresses bug HBASE-3949.
https://issues.apache.org/jira/browse/HBASE-3949
Diffs
-----
src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon 24caabd
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 6ac23d6
src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java 0f1fd04
src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 64e61bb
Diff: https://reviews.apache.org/r/3398/diff
Testing
-------
- Ran unit test TestRSStatusServlet.java {Passed}
- Ran a few simple configurations:
- No hbase.master.info.port specified (default) {Link worked}
- hbase.master.info.port specified and > 0 {Link worked}
- hbase.master.info.port specified and < 0 {Printed proper message}
Thanks,
Gregory
> Add "Master" link to RegionServer pages
> ---------------------------------------
>
> Key: HBASE-3949
> URL: https://issues.apache.org/jira/browse/HBASE-3949
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.90.3, 0.92.0
> Reporter: Lars George
> Priority: Minor
> Labels: noob
>
> Use the ZK info where the master is to add a UI link on the top of each RegionServer page. Currently you cannot navigate directly to the Master UI once you are on a RS page.
> Not sure if the info port is exposed OTTOMH, but we could either use the RS local config setting for that or add it to ZK to enable lookup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3949) Add "Master" link to RegionServer
pages
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180066#comment-13180066 ]
jiraposter@reviews.apache.org commented on HBASE-3949:
------------------------------------------------------
bq. On 2012-01-05 00:57:10, Todd Lipcon wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java, lines 241-242
bq. > <https://reviews.apache.org/r/3398/diff/1/?file=66493#file66493line241>
bq. >
bq. > I don't think it makes sense to push this as a servlet context attribute -- instead, the servlet can read it directly from the configuration itself, right? The context attributes are better for the "macro level" wiring of components.
Yes, that is a much better idea.
- Gregory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3398/#review4193
-----------------------------------------------------------
On 2012-01-05 00:49:39, Gregory Chanan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3398/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-05 00:49:39)
bq.
bq.
bq. Review request for hbase, Todd Lipcon and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch addresses HBASE-3949: Add "Master" link to RegionServer pages
bq.
bq. I used the first suggestion in the patch, "use the RS local config setting"
bq.
bq.
bq. This addresses bug HBASE-3949.
bq. https://issues.apache.org/jira/browse/HBASE-3949
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon 24caabd
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 6ac23d6
bq. src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java 0f1fd04
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 64e61bb
bq.
bq. Diff: https://reviews.apache.org/r/3398/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. - Ran unit test TestRSStatusServlet.java {Passed}
bq.
bq. - Ran a few simple configurations:
bq. - No hbase.master.info.port specified (default) {Link worked}
bq. - hbase.master.info.port specified and > 0 {Link worked}
bq. - hbase.master.info.port specified and < 0 {Printed proper message}
bq.
bq.
bq. Thanks,
bq.
bq. Gregory
bq.
bq.
> Add "Master" link to RegionServer pages
> ---------------------------------------
>
> Key: HBASE-3949
> URL: https://issues.apache.org/jira/browse/HBASE-3949
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.90.3, 0.92.0
> Reporter: Lars George
> Assignee: Gregory Chanan
> Priority: Minor
> Labels: noob
>
> Use the ZK info where the master is to add a UI link on the top of each RegionServer page. Currently you cannot navigate directly to the Master UI once you are on a RS page.
> Not sure if the info port is exposed OTTOMH, but we could either use the RS local config setting for that or add it to ZK to enable lookup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3949) Add "Master" link to RegionServer
pages
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180055#comment-13180055 ]
jiraposter@reviews.apache.org commented on HBASE-3949:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3398/#review4193
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<https://reviews.apache.org/r/3398/#comment9448>
I don't think it makes sense to push this as a servlet context attribute -- instead, the servlet can read it directly from the configuration itself, right? The context attributes are better for the "macro level" wiring of components.
src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java
<https://reviews.apache.org/r/3398/#comment9449>
style nit: spaces after commas
- Todd
On 2012-01-05 00:49:39, Gregory Chanan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3398/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-05 00:49:39)
bq.
bq.
bq. Review request for hbase, Todd Lipcon and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch addresses HBASE-3949: Add "Master" link to RegionServer pages
bq.
bq. I used the first suggestion in the patch, "use the RS local config setting"
bq.
bq.
bq. This addresses bug HBASE-3949.
bq. https://issues.apache.org/jira/browse/HBASE-3949
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon 24caabd
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 6ac23d6
bq. src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java 0f1fd04
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 64e61bb
bq.
bq. Diff: https://reviews.apache.org/r/3398/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. - Ran unit test TestRSStatusServlet.java {Passed}
bq.
bq. - Ran a few simple configurations:
bq. - No hbase.master.info.port specified (default) {Link worked}
bq. - hbase.master.info.port specified and > 0 {Link worked}
bq. - hbase.master.info.port specified and < 0 {Printed proper message}
bq.
bq.
bq. Thanks,
bq.
bq. Gregory
bq.
bq.
> Add "Master" link to RegionServer pages
> ---------------------------------------
>
> Key: HBASE-3949
> URL: https://issues.apache.org/jira/browse/HBASE-3949
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.90.3, 0.92.0
> Reporter: Lars George
> Assignee: Gregory Chanan
> Priority: Minor
> Labels: noob
>
> Use the ZK info where the master is to add a UI link on the top of each RegionServer page. Currently you cannot navigate directly to the Master UI once you are on a RS page.
> Not sure if the info port is exposed OTTOMH, but we could either use the RS local config setting for that or add it to ZK to enable lookup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-3949) Add "Master" link to RegionServer
pages
Posted by "Todd Lipcon (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon reassigned HBASE-3949:
----------------------------------
Assignee: Gregory Chanan
> Add "Master" link to RegionServer pages
> ---------------------------------------
>
> Key: HBASE-3949
> URL: https://issues.apache.org/jira/browse/HBASE-3949
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.90.3, 0.92.0
> Reporter: Lars George
> Assignee: Gregory Chanan
> Priority: Minor
> Labels: noob
>
> Use the ZK info where the master is to add a UI link on the top of each RegionServer page. Currently you cannot navigate directly to the Master UI once you are on a RS page.
> Not sure if the info port is exposed OTTOMH, but we could either use the RS local config setting for that or add it to ZK to enable lookup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3949) Add "Master" link to RegionServer
pages
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183975#comment-13183975 ]
Hudson commented on HBASE-3949:
-------------------------------
Integrated in HBase-TRUNK #2617 (See [https://builds.apache.org/job/HBase-TRUNK/2617/])
HBASE-3949. Add "Master" link to RegionServer pages. Contributed by Gregory Chanan.
todd :
Files :
* /hbase/trunk/src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java
> Add "Master" link to RegionServer pages
> ---------------------------------------
>
> Key: HBASE-3949
> URL: https://issues.apache.org/jira/browse/HBASE-3949
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.90.3, 0.92.0
> Reporter: Lars George
> Assignee: Gregory Chanan
> Priority: Minor
> Labels: noob
> Fix For: 0.94.0
>
>
> Use the ZK info where the master is to add a UI link on the top of each RegionServer page. Currently you cannot navigate directly to the Master UI once you are on a RS page.
> Not sure if the info port is exposed OTTOMH, but we could either use the RS local config setting for that or add it to ZK to enable lookup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira