You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/15 11:59:42 UTC

[GitHub] [spark] peter-toth commented on a diff in pull request #38640: [SPARK-41124][SQL][TEST] Add DSv2 PlanStabilitySuites

peter-toth commented on code in PR #38640:
URL: https://github.com/apache/spark/pull/38640#discussion_r1022701848


##########
sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala:
##########
@@ -351,6 +353,62 @@ class TPCDSModifiedPlanStabilityWithStatsSuite extends PlanStabilitySuite with T
   }
 }
 
+trait V2TPCDSBase extends TPCDSBase {
+  override protected def sparkConf: SparkConf =
+    super.sparkConf.set("spark.sql.catalog.testcat", classOf[InMemoryCatalog].getName)

Review Comment:
   You are right. Admittedly, I'm a bit lost when it comes to DSv2...
   I've just added `ParquetV2TableCatalog` for this test in: https://github.com/apache/spark/pull/38640/commits/fc9d086c10499446ec5f095368a1c06e803e9455



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org