You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by bjchambers <gi...@git.apache.org> on 2017/09/27 21:45:53 UTC

[GitHub] beam pull request #3914: [BEAM-2996] Ensure metric names are not null or emp...

GitHub user bjchambers opened a pull request:

    https://github.com/apache/beam/pull/3914

    [BEAM-2996] Ensure metric names are not null or empty

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [*] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
     - [*] Each commit in the pull request should have a meaningful subject line and body.
     - [*] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [*] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
     - [*] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
     - [*] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bjchambers/beam metric-names

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3914.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3914
    
----
commit 8635e46ca2be718e9a5a32108be177b2a096ca51
Author: bchambers <bc...@google.com>
Date:   2017-09-27T17:44:48Z

    Ensure metric names are not null or empty

----


---

[GitHub] beam pull request #3914: [BEAM-2996] Ensure metric names are not null or emp...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/3914


---