You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Milinda Pathirage <mi...@apache.org> on 2015/02/25 06:54:58 UTC
Review Request 31405: Serde Implementation or AvroData (SAMZA-575)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31405/
-----------------------------------------------------------
Review request for samza, Chris Riccomini, Yi Pan (Data Infrastructure), and Navina Ramesh.
Bugs: SAMZA-575
https://issues.apache.org/jira/browse/SAMZA-575
Repository: samza
Description
-------
Serde implementation for AvroData
Diffs
-----
samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerde.java PRE-CREATION
samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeFactory.java PRE-CREATION
samza-sql/src/test/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/31405/diff/
Testing
-------
./gradlew :samza-sql:test passed
./bin/check-all.sh gave below error which is not related to this patch.
testShouldGetOldestNewestAndNextOffsets FAILED
java.lang.AssertionError: expected:<0> but was:<null>
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.failNotEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:126)
at org.junit.Assert.assertEquals(Assert.java:145)
at org.apache.samza.system.kafka.TestKafkaSystemAdmin.testShouldGetOldestNewestAndNextOffsets(TestKafkaSystemAdmin.scala:239)
Thanks,
Milinda Pathirage
Re: Review Request 31405: Serde Implementation or AvroData (SAMZA-575)
Posted by Milinda Pathirage <mi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31405/
-----------------------------------------------------------
(Updated Feb. 25, 2015, 7:40 p.m.)
Review request for samza, Chris Riccomini, Yi Pan (Data Infrastructure), and Navina Ramesh.
Changes
-------
Changes requested during first review.
- Re-use GenericDatumWriter and GenericDatumReader
- Error logging in fromBytes method
Bugs: SAMZA-575
https://issues.apache.org/jira/browse/SAMZA-575
Repository: samza
Description
-------
Serde implementation for AvroData
Diffs (updated)
-----
samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerde.java PRE-CREATION
samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeFactory.java PRE-CREATION
samza-sql/src/test/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/31405/diff/
Testing
-------
./gradlew :samza-sql:test passed
./bin/check-all.sh gave below error which is not related to this patch.
testShouldGetOldestNewestAndNextOffsets FAILED
java.lang.AssertionError: expected:<0> but was:<null>
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.failNotEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:126)
at org.junit.Assert.assertEquals(Assert.java:145)
at org.apache.samza.system.kafka.TestKafkaSystemAdmin.testShouldGetOldestNewestAndNextOffsets(TestKafkaSystemAdmin.scala:239)
Thanks,
Milinda Pathirage
Re: Review Request 31405: Serde Implementation or AvroData (SAMZA-575)
Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31405/#review74065
-----------------------------------------------------------
Looks good!
- Navina Ramesh
On Feb. 25, 2015, 5:54 a.m., Milinda Pathirage wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31405/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 5:54 a.m.)
>
>
> Review request for samza, Chris Riccomini, Yi Pan (Data Infrastructure), and Navina Ramesh.
>
>
> Bugs: SAMZA-575
> https://issues.apache.org/jira/browse/SAMZA-575
>
>
> Repository: samza
>
>
> Description
> -------
>
> Serde implementation for AvroData
>
>
> Diffs
> -----
>
> samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerde.java PRE-CREATION
> samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeFactory.java PRE-CREATION
> samza-sql/src/test/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31405/diff/
>
>
> Testing
> -------
>
> ./gradlew :samza-sql:test passed
>
> ./bin/check-all.sh gave below error which is not related to this patch.
>
> testShouldGetOldestNewestAndNextOffsets FAILED
> java.lang.AssertionError: expected:<0> but was:<null>
> at org.junit.Assert.fail(Assert.java:91)
> at org.junit.Assert.failNotEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:126)
> at org.junit.Assert.assertEquals(Assert.java:145)
> at org.apache.samza.system.kafka.TestKafkaSystemAdmin.testShouldGetOldestNewestAndNextOffsets(TestKafkaSystemAdmin.scala:239)
>
>
> Thanks,
>
> Milinda Pathirage
>
>
Re: Review Request 31405: Serde Implementation or AvroData (SAMZA-575)
Posted by Milinda Pathirage <mi...@apache.org>.
> On Feb. 25, 2015, 7:12 p.m., Chris Riccomini wrote:
> > samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerde.java, line 51
> > <https://reviews.apache.org/r/31405/diff/1/?file=875232#file875232line51>
> >
> > Do we need to create a new datum reader every time we call from bytes?
I was not sure about the thread safety of GenericDataReader. Looks like it is thread safe and re-using is okay (http://mail-archives.apache.org/mod_mbox/avro-user/201406.mbox/%3CCALEq1Z8-NeQNWG4BSys9sQFAjsjpt5rPsGgSH8fZfgUTupjkDA@mail.gmail.com%3E). I'll fix this.
> On Feb. 25, 2015, 7:12 p.m., Chris Riccomini wrote:
> > samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerde.java, line 73
> > <https://reviews.apache.org/r/31405/diff/1/?file=875232#file875232line73>
> >
> > Any reason this doesn't match lines [56-58] in fromBytes?
This should match [56-58]. I'll fix this.
- Milinda
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31405/#review74060
-----------------------------------------------------------
On Feb. 25, 2015, 5:54 a.m., Milinda Pathirage wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31405/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 5:54 a.m.)
>
>
> Review request for samza, Chris Riccomini, Yi Pan (Data Infrastructure), and Navina Ramesh.
>
>
> Bugs: SAMZA-575
> https://issues.apache.org/jira/browse/SAMZA-575
>
>
> Repository: samza
>
>
> Description
> -------
>
> Serde implementation for AvroData
>
>
> Diffs
> -----
>
> samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerde.java PRE-CREATION
> samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeFactory.java PRE-CREATION
> samza-sql/src/test/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31405/diff/
>
>
> Testing
> -------
>
> ./gradlew :samza-sql:test passed
>
> ./bin/check-all.sh gave below error which is not related to this patch.
>
> testShouldGetOldestNewestAndNextOffsets FAILED
> java.lang.AssertionError: expected:<0> but was:<null>
> at org.junit.Assert.fail(Assert.java:91)
> at org.junit.Assert.failNotEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:126)
> at org.junit.Assert.assertEquals(Assert.java:145)
> at org.apache.samza.system.kafka.TestKafkaSystemAdmin.testShouldGetOldestNewestAndNextOffsets(TestKafkaSystemAdmin.scala:239)
>
>
> Thanks,
>
> Milinda Pathirage
>
>
Re: Review Request 31405: Serde Implementation or AvroData (SAMZA-575)
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31405/#review74060
-----------------------------------------------------------
samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerde.java
<https://reviews.apache.org/r/31405/#comment120561>
Do we need to create a new datum reader every time we call from bytes?
samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerde.java
<https://reviews.apache.org/r/31405/#comment120566>
Same question as above for reader.
samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerde.java
<https://reviews.apache.org/r/31405/#comment120567>
Any reason this doesn't match lines [56-58] in fromBytes?
- Chris Riccomini
On Feb. 25, 2015, 5:54 a.m., Milinda Pathirage wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31405/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 5:54 a.m.)
>
>
> Review request for samza, Chris Riccomini, Yi Pan (Data Infrastructure), and Navina Ramesh.
>
>
> Bugs: SAMZA-575
> https://issues.apache.org/jira/browse/SAMZA-575
>
>
> Repository: samza
>
>
> Description
> -------
>
> Serde implementation for AvroData
>
>
> Diffs
> -----
>
> samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerde.java PRE-CREATION
> samza-sql/src/main/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeFactory.java PRE-CREATION
> samza-sql/src/test/java/org/apache/samza/sql/data/serializers/SqlAvroSerdeTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31405/diff/
>
>
> Testing
> -------
>
> ./gradlew :samza-sql:test passed
>
> ./bin/check-all.sh gave below error which is not related to this patch.
>
> testShouldGetOldestNewestAndNextOffsets FAILED
> java.lang.AssertionError: expected:<0> but was:<null>
> at org.junit.Assert.fail(Assert.java:91)
> at org.junit.Assert.failNotEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:126)
> at org.junit.Assert.assertEquals(Assert.java:145)
> at org.apache.samza.system.kafka.TestKafkaSystemAdmin.testShouldGetOldestNewestAndNextOffsets(TestKafkaSystemAdmin.scala:239)
>
>
> Thanks,
>
> Milinda Pathirage
>
>