You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Cody Maloney <co...@mesosphere.io> on 2014/09/29 23:55:15 UTC
Review Request 26152: Remove unused stout tuples/ folder
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26152/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Dominic Hamon, and Till Toenshoff.
Repository: mesos-git
Description
-------
None of these are included by anything in the codebase. They don't seem to have been used since at least MESOS-1026 or so when we switched to <tuple> and <tr1/tuple> .
Diffs
-----
3rdparty/libprocess/include/process/tuples/details.hpp f198f0e
3rdparty/libprocess/include/process/tuples/tuples.hpp f993b01
Diff: https://reviews.apache.org/r/26152/diff/
Testing
-------
make check
Thanks,
Cody Maloney
Re: Review Request 26152: Remove unused stout tuples/ folder
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26152/#review54936
-----------------------------------------------------------
Ship it!
Thank you. The subject threw me off a bit since it says stout (which are actually used), but this is for libprocess.
- Ben Mahler
On Sept. 29, 2014, 9:55 p.m., Cody Maloney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26152/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 9:55 p.m.)
>
>
> Review request for mesos, Ben Mahler, Dominic Hamon, and Till Toenshoff.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> None of these are included by anything in the codebase. They don't seem to have been used since at least MESOS-1026 or so when we switched to <tuple> and <tr1/tuple> .
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/tuples/details.hpp f198f0e
> 3rdparty/libprocess/include/process/tuples/tuples.hpp f993b01
>
> Diff: https://reviews.apache.org/r/26152/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Cody Maloney
>
>
Re: Review Request 26152: Remove unused stout tuples/ folder
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26152/#review54933
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26152]
All tests passed.
- Mesos ReviewBot
On Sept. 29, 2014, 9:55 p.m., Cody Maloney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26152/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2014, 9:55 p.m.)
>
>
> Review request for mesos, Ben Mahler, Dominic Hamon, and Till Toenshoff.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> None of these are included by anything in the codebase. They don't seem to have been used since at least MESOS-1026 or so when we switched to <tuple> and <tr1/tuple> .
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/tuples/details.hpp f198f0e
> 3rdparty/libprocess/include/process/tuples/tuples.hpp f993b01
>
> Diff: https://reviews.apache.org/r/26152/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Cody Maloney
>
>