[GitHub] [hadoop] brianloss commented on pull request #3221: HADOOP-17811: Configure ExponentialRetryPolicy

[GitBox <gi...@apache.org>]

brianloss commented on pull request #3221:
URL: https://github.com/apache/hadoop/pull/3221#issuecomment-887721735


   > Seems reasonable; made some minor suggestions.
   > 
   
   @steveloughran, thanks for taking a look! I addressed the suggestions that I thought made sense, and will push them in just a minute.
   
   > One thing I like for config options is to be able to include the unit (time, capacity) in the option, e.g "500ms", "2min". `Configuration.getTimeDuration()` does this, including allowing a default time unit to retrofit the feature to existing properties.
   > 
   > Can we use that here? It may need a change in the ABFS config
   
   I like the idea, but it looks like it will be a more involved change since the configuration properties are read via annotation-driven code and updating that will be much more involved. I'm happy to take a look, but was thinking that should be a separate issue/PR. 
   
   > 
   > Also please look at the policy in `testing_azure.md` and declare which abfs endpoint you tested against. No declaration: no review. Sorry, but we have to be this strict because we can't give yetus any credentials
   
   I did what I could here in East US. The instructions aren't clear as to what **must** be done. I ran the runtests.sh script, according to the `Testing the Azure ABFS Client` section. I found several tests to be flaky, and all seem to be unrelated to my change. I had failures in the following tests, but they all succeeded when I ran individually:
   
   - ITestAbfsStreamStatistics.testAbfsStreamOps (failed in AppendBlob-HNS-OAuth)
   - ITestAzureBlobFileSystemLease.testTwoWritersCreateAppendNoInfiniteLease (failed in AppendBlob-HNS-OAuth)
   - ITestAzureBlobFileSystemRandomRead.testValidateSeekBounds (failed in HNS-OAuth and HNS-SharedKey)
   - ITestAbfsRestOperationException.testCustomTokenFetchRetryCount (failed in NonHNS-SharedKey)
   - ITestGetNameSpaceEnabled.testGetIsNamespaceEnabledWhenConfigIsFalse (failed in NonHNS-SharedKey)
   - ITestGetNameSpaceEnabled.testGetIsNamespaceEnabledWhenConfigIsTrue (failed in NonHNS-SharedKey)
   - ITestGetNameSpaceEnabled.testNonXNSAccount (failed in NonHNS-SharedKey)
   
   I also had failures in ITestAzureBlobFileSystemLease.testFileSystemClose and ITestAzureBlobFileSystemLease.testTwoCreate. These fail when I run individually and also fail when I run the tests on trunk. I am also unable to get ITestAzureBlobFileSystemCheckAccess.testCheckAccessForAccountWithoutNS to pass (on either my branch or trunk) despite following the special instructions for that.
   
   Please let me know if there's anything else I need to run/test. Thanks.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org