You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by ru...@apache.org on 2023/04/06 01:33:29 UTC

[iceberg] branch master updated: Core: Fix flakiness in HadoopFileIOTest (#7253)

This is an automated email from the ASF dual-hosted git repository.

russellspitzer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/master by this push:
     new 7c61537194 Core: Fix flakiness in HadoopFileIOTest (#7253)
7c61537194 is described below

commit 7c61537194f9ab68e3d83a16b339ec47180f5f10
Author: Eduard Tudenhoefner <et...@gmail.com>
AuthorDate: Thu Apr 6 03:33:23 2023 +0200

    Core: Fix flakiness in HadoopFileIOTest (#7253)
    
    * Core: Fix flakiness in HadoopFileIOTest
    
    Replaces non-thread-safe arraylist with thread-safe vector
---
 core/src/test/java/org/apache/iceberg/hadoop/HadoopFileIOTest.java | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/core/src/test/java/org/apache/iceberg/hadoop/HadoopFileIOTest.java b/core/src/test/java/org/apache/iceberg/hadoop/HadoopFileIOTest.java
index 7920eae54b..818dfaabc6 100644
--- a/core/src/test/java/org/apache/iceberg/hadoop/HadoopFileIOTest.java
+++ b/core/src/test/java/org/apache/iceberg/hadoop/HadoopFileIOTest.java
@@ -27,6 +27,7 @@ import java.io.UncheckedIOException;
 import java.util.List;
 import java.util.Random;
 import java.util.UUID;
+import java.util.Vector;
 import java.util.stream.Collectors;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.fs.FileSystem;
@@ -48,7 +49,7 @@ public class HadoopFileIOTest {
   private FileSystem fs;
   private HadoopFileIO hadoopFileIO;
 
-  @TempDir static File tempDir;
+  @TempDir private File tempDir;
 
   @BeforeEach
   public void before() throws Exception {
@@ -165,7 +166,7 @@ public class HadoopFileIOTest {
   }
 
   private List<Path> createRandomFiles(Path parent, int count) {
-    List<Path> paths = Lists.newArrayList();
+    Vector<Path> paths = new Vector<>();
     random
         .ints(count)
         .parallel()