[GitHub] [bookkeeper] Shoothzj commented on a diff in pull request #4020: PerChannelBookieClient Enhancement: Self-Recovery Support in Corrupte…

["Shoothzj (via GitHub)" <gi...@apache.org>]

Shoothzj commented on code in PR #4020:
URL: https://github.com/apache/bookkeeper/pull/4020#discussion_r1264835430


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java:
##########
@@ -1043,6 +1043,9 @@ public void checkTimeoutOnPendingOperations() {
         if (timedOutOperations > 0) {
             LOG.info("Timed-out {} operations to channel {} for {}",
                      timedOutOperations, channel, bookieId);
+            // In scenarios with message tampering, communication timeout can lead to an unrecoverable state.
+            this.disconnect();

Review Comment:
   @hangc0276 I believe there shouldn't be an issue here. However, if everyone feels that its impact is significant or it's too sensitive, we might consider adding a threshold for reconnection.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org