You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Zhen Zhang <ne...@gmail.com> on 2015/01/15 20:48:17 UTC
Review Request 29941: [HELIX-562] TaskRebalancer doesn't honor
MaxAttemptsPerTask when FailureThreshold is larger than 0
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29941/
-----------------------------------------------------------
Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi Lu.
Bugs: HELIX-562
Repository: helix-git
Description
-------
When FailureThreshold is larger than 0, TaskRebalancer will retry indefiniltely
Diffs
-----
helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java d9b70d4
helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java a073b93
helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancerRetryLimit.java e69de29
Diff: https://reviews.apache.org/r/29941/diff/
Testing
-------
mvn test
Thanks,
Zhen Zhang
Re: Review Request 29941: [HELIX-562] TaskRebalancer doesn't honor
MaxAttemptsPerTask when FailureThreshold is larger than 0
Posted by Kishore Gopalakrishna <ki...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29941/#review68317
-----------------------------------------------------------
Ship it!
- Kishore Gopalakrishna
On Jan. 15, 2015, 7:48 p.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29941/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2015, 7:48 p.m.)
>
>
> Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi Lu.
>
>
> Bugs: HELIX-562
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> When FailureThreshold is larger than 0, TaskRebalancer will retry indefiniltely
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java d9b70d4
> helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java a073b93
> helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancerRetryLimit.java e69de29
>
> Diff: https://reviews.apache.org/r/29941/diff/
>
>
> Testing
> -------
>
> mvn test
>
>
> Thanks,
>
> Zhen Zhang
>
>