You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/29 14:44:50 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4248: mtd: Return MTD first block info on MTDIOC_GEOMETRY

gustavonihei commented on a change in pull request #4248:
URL: https://github.com/apache/incubator-nuttx/pull/4248#discussion_r679219317



##########
File path: include/nuttx/mtd/mtd.h
##########
@@ -74,6 +74,9 @@
 #define MTDIOC_ERASESTATE _MTDIOC(0x000a) /* IN:  Pointer to uint8_t
                                            * OUT: Byte value that represents the
                                            *      erased state of the MTD cell */
+#define MTDIOC_FIRSTBLOCK _MTDIOC(0x000b) /* IN:  Pointer to off_t

Review comment:
       > block device also need similar change.
   
   I've just seen that block device partitions also handle `MTDIOC_GEOMETRY`, is this what you were referring to?
   https://github.com/apache/incubator-nuttx/blob/fd19c36f5b7d36fb5b19946e035b5bff2d1b8628/fs/driver/fs_blockpartition.c#L249
   
   Or do you mean to also add a new field to `struct geometry`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org