You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Martin Hauner <ma...@gmx.net> on 2005/10/02 12:52:23 UTC
[PATCH] V3, diff summarize (preview) without text deltas
Hi,
attached is the third version of the diff summarize api call that doesn't
produce text deltas (which helps to build a nice diff interface in a gui
client or at least that's why i did write it :) This is also partially
issue #2015 (without -v).
I have fixed/updated it based on Peter Lundblads nice review and cleaned
up a few other things.
I have also fixed the code duplication with the normal diff code that I
had originally planned for another patch (that added another 25 KByte to
the patch ;)
Since the previous version of the patch is out of everyones mind remember
that
* this is an api only patch. For easier review I attached another small
patch to run summarize from the command line, ie. svn diff -s.
* the summarize currently handles only the repository <-> repository case.
Happy reviewing :)
--
Martin
Subcommander, http://subcommander.tigris.org
a cross platform Win32/Unix/MacOSX subversion gui client & diff/merge tool.
Re: [PATCH] V3, diff summarize (preview) without text deltas
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Sun, 2 Oct 2005, Martin Hauner wrote:
> attached is the third version of the diff summarize api call that doesn't
> produce text deltas (which helps to build a nice diff interface in a gui
> client or at least that's why i did write it :) This is also partially
> issue #2015 (without -v).
>
r16476. As I said before, I reworked it a bit. I did basic testing with
your client patch.
Thanks for the patch,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] V3, diff summarize (preview) without text deltas
Posted by Martin Hauner <ma...@gmx.net>.
Peter N. Lundblad wrote:
> On Sun, 2 Oct 2005, Martin Hauner wrote:
>
>
>>attached is the third version of the diff summarize api call that doesn't
>>produce text deltas (which helps to build a nice diff interface in a gui
>>client or at least that's why i did write it :) This is also partially
>>issue #2015 (without -v).
>>
>>I have fixed/updated it based on Peter Lundblads nice review and cleaned
>>up a few other things.
>>
>
> Thanks for those kind words:-) Just FYI, I'm in the process of applying
> this patch, since it looks very good overall. There are small style nits
> here and there, which I'm fixing as I go through the patch.
Cool, thanks :)
> I'm doing one
> larger change, though. INstead of one kind field and two boolean fields in
> svn_client_diff_summarize_t, I'm combining item and text "status" into one
> filed as we do in the status APIs. I think that's more intuitive.
Funny, i have changed it in this patch to use two booleans instead of one
thinking this might be easier to understand. ;) But it was a bit strange
to use from my gui client. So i guess combining item and text status again
is the better solution.
--
Martin
Subcommander, http://subcommander.tigris.org
a cross platform Win32/Unix/MacOSX subversion gui client & diff/merge tool.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] V3, diff summarize (preview) without text deltas
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Sun, 2 Oct 2005, Martin Hauner wrote:
> attached is the third version of the diff summarize api call that doesn't
> produce text deltas (which helps to build a nice diff interface in a gui
> client or at least that's why i did write it :) This is also partially
> issue #2015 (without -v).
>
> I have fixed/updated it based on Peter Lundblads nice review and cleaned
> up a few other things.
>
Thanks for those kind words:-) Just FYI, I'm in the process of applying
this patch, since it looks very good overall. There are small style nits
here and there, which I'm fixing as I go through the patch. I'm doing one
larger change, though. INstead of one kind field and two boolean fields in
svn_client_diff_summarize_t, I'm combining item and text "status" into one
filed as we do in the status APIs. I think that's more intuitive. Also,
I'm getting rid of the _unchanged kind, which is only used internally and
therefore shouldn't be exposed.
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org