You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/09/28 07:19:01 UTC
[GitHub] [incubator-linkis] binbinCheng opened a new pull request, #3550: [linkis-module]module errorcode optimization and documentation
binbinCheng opened a new pull request, #3550:
URL: https://github.com/apache/incubator-linkis/pull/3550
**[linkis-module]module errorcode optimization and documentation**
Related issues: #3424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone merged pull request #3550: [linkis-module]module errorcode optimization and documentation
Posted by GitBox <gi...@apache.org>.
casionone merged PR #3550:
URL: https://github.com/apache/incubator-linkis/pull/3550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #3550: [linkis-module]module errorcode optimization and documentation
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #3550:
URL: https://github.com/apache/incubator-linkis/pull/3550#discussion_r996392533
##########
linkis-commons/linkis-module/src/main/scala/org/apache/linkis/server/security/SSOUtils.scala:
##########
@@ -209,7 +205,7 @@ object SSOUtils extends Logging {
) > sessionTimeout
) {
userTicketIdToLastAccessTime.remove(userTicketId)
- throw new LoginExpireException("Login has expired, please log in again!(登录已过期，请重新登录！)")
+ throw new LoginExpireException(NOT_LOGGED.getErrorDesc)
Review Comment:
"Login has expired, please log in again!(登录已过期，请重新登录！"
not
"You are not logged in, please login first!(您尚未登录，请先登录!)"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #3550: [linkis-module]module errorcode optimization and documentation
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #3550:
URL: https://github.com/apache/incubator-linkis/pull/3550#issuecomment-1260523736
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/3550?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3550](https://codecov.io/gh/apache/incubator-linkis/pull/3550?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (88ae223) into [dev-1.3.1](https://codecov.io/gh/apache/incubator-linkis/commit/df850bb83cef08284b25201c9fc3ec67a92b825e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df850bb) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## dev-1.3.1 #3550 +/- ##
============================================
Coverage 13.77% 13.77%
- Complexity 1306 1307 +1
============================================
Files 876 876
Lines 33820 33820
Branches 4914 4914
============================================
Hits 4660 4660
Misses 28506 28506
Partials 654 654
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/3550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...main/scala/org/apache/linkis/rpc/RPCMapCache.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3550/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXJwYy9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9ycGMvUlBDTWFwQ2FjaGUuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...a/org/apache/linkis/scheduler/queue/Consumer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3550/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvQ29uc3VtZXIuc2NhbGE=) | `85.71% <0.00%> (-14.29%)` | :arrow_down: |
| [...r/engineplugin/python/executor/PythonSession.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3550/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9weXRob24vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9saW5raXMvbWFuYWdlci9lbmdpbmVwbHVnaW4vcHl0aG9uL2V4ZWN1dG9yL1B5dGhvblNlc3Npb24uc2NhbGE=) | `58.41% <0.00%> (-0.50%)` | :arrow_down: |
| [...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3550/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvZmlmb3F1ZXVlL0ZJRk9Vc2VyQ29uc3VtZXIuc2NhbGE=) | `38.67% <0.00%> (+1.88%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org