[GitHub] [cordova-plugin-file] jcesarmobile commented on a change in pull request #513: feat(android): add WebViewAssetLoader proxy handler for cdvfile

[GitBox <gi...@apache.org>]

jcesarmobile commented on a change in pull request #513:
URL: https://github.com/apache/cordova-plugin-file/pull/513#discussion_r810698517



##########
File path: plugin.xml
##########
@@ -153,6 +153,8 @@ to config.xml in order for the application to find previously stored files.
         <source-file src="src/android/AssetFilesystem.java" target-dir="src/org/apache/cordova/file" />
         <source-file src="src/android/PendingRequests.java" target-dir="src/org/apache/cordova/file" />
 
+        <framework src="androidx.webkit:webkit:1.3.0" type="gradleReference" />

Review comment:
       The version should be configurable. And gradleReference is used for gradle files, not for maven dependencies.
   You can check camera plugin for reference
   https://github.com/apache/cordova-plugin-camera/blob/master/plugin.xml#L98




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org