You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "dannycranmer (via GitHub)" <gi...@apache.org> on 2023/04/13 09:40:31 UTC
[GitHub] [flink-connector-jdbc] dannycranmer opened a new pull request, #39: [FLINK-31699][Connectors/JDBC] Fixing dependency convergence
dannycranmer opened a new pull request, #39:
URL: https://github.com/apache/flink-connector-jdbc/pull/39
Fixes https://github.com/apache/flink-connector-jdbc/actions/runs/4687686153/jobs/8307285788
Tested via
- `mvn clean install -Pcheck-convergence -Dflink.version=1.16.1`
- `mvn clean install -Pcheck-convergence -Dflink.version=1.17.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-jdbc] MartijnVisser commented on a diff in pull request #39: [FLINK-31699][Connectors/JDBC] Fixing dependency convergence
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #39:
URL: https://github.com/apache/flink-connector-jdbc/pull/39#discussion_r1165293180
##########
pom.xml:
##########
@@ -48,7 +48,7 @@ under the License.
<properties>
<flink.version>1.16.0</flink.version>
- <flink.shaded.version>15.0</flink.shaded.version>
+ <flink.shaded.version>16.1</flink.shaded.version>
Review Comment:
We actually should create a follow-up ticket because connectors shouldn't rely on Flink Shaded at all, like we've also done for Cassandra https://issues.apache.org/jira/browse/FLINK-31722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-jdbc] dannycranmer commented on a diff in pull request #39: [FLINK-31699][Connectors/JDBC] Fixing dependency convergence
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer commented on code in PR #39:
URL: https://github.com/apache/flink-connector-jdbc/pull/39#discussion_r1165324674
##########
pom.xml:
##########
@@ -48,7 +48,7 @@ under the License.
<properties>
<flink.version>1.16.0</flink.version>
- <flink.shaded.version>15.0</flink.shaded.version>
+ <flink.shaded.version>16.1</flink.shaded.version>
Review Comment:
https://issues.apache.org/jira/browse/FLINK-31793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-jdbc] dannycranmer merged pull request #39: [FLINK-31699][Connectors/JDBC] Fixing dependency convergence
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer merged PR #39:
URL: https://github.com/apache/flink-connector-jdbc/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org