You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/02/05 10:36:03 UTC
[GitHub] [hadoop] mehakmeet commented on a change in pull request #2667: HADOOP-16906. Add Abortable.abort() interface for streams to enable output stream to be terminated
mehakmeet commented on a change in pull request #2667:
URL: https://github.com/apache/hadoop/pull/2667#discussion_r570838580
##########
File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ITestS3AMultipartUploadSizeLimits.java
##########
@@ -20,6 +20,9 @@
import java.io.File;
+import org.apache.hadoop.fs.FSDataOutputStream;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.io.IOUtils;
Review comment:
reposition in ```org.apache.*``` block below.
##########
File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ITestS3AMultipartUploadSizeLimits.java
##########
@@ -118,4 +121,29 @@ public void testCommitLimitFailure() throws Throwable {
describedAs("commit abort count")
.isEqualTo(initial + 1);
}
+
+ @Test
+ public void testAbortAfterTwoPartUpload() throws Throwable {
Review comment:
javadoc or describe() to explain the test.
##########
File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ABlockOutputStream.java
##########
@@ -37,6 +37,7 @@
import com.amazonaws.services.s3.model.PutObjectRequest;
import com.amazonaws.services.s3.model.PutObjectResult;
import com.amazonaws.services.s3.model.UploadPartRequest;
+import org.apache.hadoop.fs.Abortable;
Review comment:
reposition in ```org.apache.*``` block below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org