You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/22 15:04:53 UTC
[GitHub] [arrow] vibhatha commented on a diff in pull request #14199: ARROW-17614: [CI][Python] test test_write_dataset_max_rows_per_file is producing several nightly build failures
vibhatha commented on code in PR #14199:
URL: https://github.com/apache/arrow/pull/14199#discussion_r977773325
##########
cpp/src/arrow/dataset/dataset_writer.cc:
##########
@@ -348,9 +348,9 @@ class DatasetWriterDirectoryQueue {
util::AsyncTaskScheduler::Throttle* throttle_view = throttle.get();
util::AsyncTaskScheduler* file_scheduler = scheduler_->MakeSubScheduler(
FileFinishTask{this, std::move(file_queue), std::move(throttle)}, throttle_view);
- if (init_task_) {
- file_scheduler->AddSimpleTask(init_task_);
- init_task_ = {};
+ if (init_future_.is_valid()) {
Review Comment:
What happens if this is not valid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org