You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/09/02 06:58:21 UTC

[GitHub] [airflow] TobKed commented on a change in pull request #5980: [AIRFLOW-5129] Add typehint to GCP DLP hook

TobKed commented on a change in pull request #5980: [AIRFLOW-5129] Add typehint to GCP DLP hook
URL: https://github.com/apache/airflow/pull/5980#discussion_r319809452
 
 

 ##########
 File path: airflow/gcp/hooks/dlp.py
 ##########
 @@ -53,28 +66,34 @@ class CloudDLPHook(GoogleCloudBaseHook):
     :type delegate_to: str
     """
 
-    def __init__(self,
-                 gcp_conn_id="google_cloud_default",
-                 delegate_to=None):
+    def __init__(self, gcp_conn_id="google_cloud_default", delegate_to=None):
 
 Review comment:
   Could you add type hints here as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services