You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/12/08 00:48:06 UTC

[GitHub] rahul003 opened a new pull request #8993: Update instructions and fix compatibility of examples

rahul003 opened a new pull request #8993: Update instructions and fix compatibility of examples
URL: https://github.com/apache/incubator-mxnet/pull/8993
 
 
   ## Description ##
   Fixes compatibility issues of example/rcnn and example/sparse to run with python3
   
   ## Checklist ##
   ### Essentials ###
   - [ ] Passed code style checking (`make lint`)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] For user-facing API changes, API doc string has been updated. For new C++ functions in header files, their functionalities and arguments are well-documented. 
   - [ ] To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   To ensure compatibility of example/rcnn with py2.7 and py3.6
   - [ ] Use six.moves.cPickle 
   - [ ] Remove xrange to use builtins.range
   - [ ] Change how modules are imported
   - [ ] Update usage of numpy to ensure we are not calling deprecated APIs. Example using float to index an array has been removed from numpy. Now we need to cast it to int first.
   - [ ] Updated readme
   
   To ensure compatibility of example/sparse with py3.6
   - [ ] An assert statement was comparing string and float causing type error on py3.6
   
   To ensure example/sparse runs on Mac
   - [ ] Updates scripts to fetch data to use common API for Mac and Linux. Removed wget.
   - [ ] Updated get_bz2_data to extract file line by line. Else it fails on Mac as MacOS doesn't support that feature for large files.
   - [ ] Added get_zip_data in test_utils, which works on both Mac and Linux
   
   
   ## Comments ##
   - example/rcnn now needs pip packages builtins and six even for py2.7 so we can use same API for both py2.7 and py3.6. This is not a big deal since this is an advanced example and already requires 4-5 pip packages to run
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services