You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Mark Thomas <ma...@apache.org> on 2009/01/14 14:59:19 UTC
RE: svn commit: r734396 - in /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp: BasicDataSource.java PoolingDataSource.java datasources/InstanceKeyDataSource.java
> From: markt@apache.org [mailto:markt@apache.org]
> Log:
> Add build flags to new JDBC 4 methods that use generics
With this commit:
- DBCP builds and all tests pass on a 1.6 JDK
- DBCP builds and all tests pass on a 1.5 JDK (with source=1.4)
- DBCP builds on a 1.4 JDK
I can't run the tests very easily on a 1.4 JDK as the geronimo jars that the tests depends on have been built with a 1.5 JDK.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
RE: svn commit: r734396 - in /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp: BasicDataSource.java PoolingDataSource.java datasources/InstanceKeyDataSource.java
Posted by Mark Thomas <ma...@apache.org>.
> -----Original Message-----
> From: sebb [mailto:sebbaz@gmail.com]
> Sent: 14 January 2009 14:31
> To: Commons Developers List
> Subject: Re: svn commit: r734396 - in
> /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp:
> BasicDataSource.java PoolingDataSource.java
> datasources/InstanceKeyDataSource.java
>
> On 14/01/2009, Mark Thomas <ma...@apache.org> wrote:
> > > From: markt@apache.org [mailto:markt@apache.org]
> > > Log:
> > > Add build flags to new JDBC 4 methods that use generics
> >
> > With this commit:
> > - DBCP builds and all tests pass on a 1.6 JDK
> > - DBCP builds and all tests pass on a 1.5 JDK (with source=1.4)
> > - DBCP builds on a 1.4 JDK
>
> Was that using Maven1, Maven2 or Ant?
It was with Ant.
> I get test errors using Java 1.6 with Ant, but that may be due to some
> jars missing from the classpath. It looks like the Ant build depends
> on finding everything in the Maven1 repository.
I had to go digging through the build script to figure out which JARs I
needed to add. I'll update the sample properties file shortly.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r734396 - in /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp:
BasicDataSource.java PoolingDataSource.java datasources/InstanceKeyDataSource.java
Posted by sebb <se...@gmail.com>.
On 14/01/2009, Mark Thomas <ma...@apache.org> wrote:
> > From: markt@apache.org [mailto:markt@apache.org]
> > Log:
> > Add build flags to new JDBC 4 methods that use generics
>
> With this commit:
> - DBCP builds and all tests pass on a 1.6 JDK
> - DBCP builds and all tests pass on a 1.5 JDK (with source=1.4)
> - DBCP builds on a 1.4 JDK
Was that using Maven1, Maven2 or Ant?
I get test errors using Java 1.6 with Ant, but that may be due to some
jars missing from the classpath. It looks like the Ant build depends
on finding everything in the Maven1 repository.
> I can't run the tests very easily on a 1.4 JDK as the geronimo jars that the tests depends on have been built with a 1.5 JDK.
>
> Mark
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org