You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/26 16:26:43 UTC
[GitHub] [beam] lukecwik commented on a change in pull request #12104: [BEAM-10334] Increase default grpc message length
lukecwik commented on a change in pull request #12104:
URL: https://github.com/apache/beam/pull/12104#discussion_r446283329
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker.py
##########
@@ -145,14 +145,16 @@ def __init__(self,
self._worker_index = 0
self._worker_id = worker_id
self._state_cache = StateCache(state_cache_size)
+ options = [('grpc.max_receive_message_length', -1),
+ ('grpc.max_send_message_length', -1)]
if credentials is None:
_LOGGER.info('Creating insecure control channel for %s.', control_address)
self._control_channel = GRPCChannelFactory.insecure_channel(
- control_address)
+ control_address, options = options)
else:
_LOGGER.info('Creating secure control channel for %s.', control_address)
self._control_channel = GRPCChannelFactory.secure_channel(
- control_address, credentials)
+ control_address, credentials, options = options)
Review comment:
```
09:09:24 > Task :sdks:python:test-suites:tox:py37:lintPy37
09:09:24 ************* Module apache_beam.runners.worker.sdk_worker
09:09:24 apache_beam/runners/worker/sdk_worker.py:153:35: C0326: No space allowed around keyword argument assignment
09:09:24 control_address, options = options)
09:09:24 ^ (bad-whitespace)
09:09:24 apache_beam/runners/worker/sdk_worker.py:157:48: C0326: No space allowed around keyword argument assignment
09:09:24 control_address, credentials, options = options)
09:09:24 ^ (bad-whitespace)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org